openstack
/
ironic
Code Issues Proposed changes

display error logging should be improved 

Removed duplicate error logging

Change-Id: Id953a79b7db56b4014727d402104a9e998e55255
Closes-Bug: 1286374
This commit is contained in:
Vic Howard 2015-01-02 11:06:12 -05:00
parent d74a5cd00c
commit d1f7eddb9e
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ironic/common/glance_service/base_image_service.py
View File

@ -124,26 +124,18 @@ class BaseImageService(object):
except retry_excs as e:
host = self.glance_host
port = self.glance_port
extra = "retrying"
error_msg = _LE("Error contacting glance server "
"'%(host)s:%(port)s' for '%(method)s', "
"%(extra)s.")
"'%(host)s:%(port)s' for '%(method)s', attempt"
" %(attempt)s of %(num_attempts)s failed.")
LOG.exception(error_msg, {'host': host,
'port': port,
'num_attempts': num_attempts,
'attempt': attempt,
'method': method})
if attempt == num_attempts:
extra = 'done trying'
LOG.exception(error_msg, {'host': host,
'port': port,
'num_attempts': num_attempts,
'method': method,
'extra': extra})
raise exception.GlanceConnectionFailed(host=host,
port=port,
reason=str(e))
LOG.exception(error_msg, {'host': host,
'port': port,
'num_attempts': num_attempts,
'attempt': attempt,
'method': method,
'extra': extra})
time.sleep(1)
except image_excs as e:
exc_type, exc_value, exc_trace = sys.exc_info()