Small refactor for create nonlocal user
This change refactors the local user attribute key deletion when creating a new nonlocal user to simply pop the specific keys instead of creating a separate list and iterating over it in order to accomplish the same result. Based on this[0] previous comment. [0] https://review.openstack.org/#/c/357979/4/keystone/identity/shadow_backends/sql.py Change-Id: Ice8c08d192f6eea84a6a05975177be026b1e8929
This commit is contained in:
parent
9d366a528b
commit
79be1dc10c
|
@ -143,10 +143,8 @@ class ShadowUsers(base.ShadowUsersDriverBase):
|
|||
def create_nonlocal_user(self, user_dict):
|
||||
new_user_dict = copy.deepcopy(user_dict)
|
||||
# remove local_user attributes from new_user_dict
|
||||
keys_to_delete = ['name', 'password']
|
||||
for key in keys_to_delete:
|
||||
if key in new_user_dict:
|
||||
del new_user_dict[key]
|
||||
new_user_dict.pop('name', None)
|
||||
new_user_dict.pop('password', None)
|
||||
# create nonlocal_user dict
|
||||
new_nonlocal_user_dict = {
|
||||
'name': user_dict['name']
|
||||
|
|
Loading…
Reference in New Issue