openstack
/
keystone
Code Issues Proposed changes

Refactor test_backend_ldap tests 

Currently, the testing backend for LDAP relies on multiple inheritance
of many base and testing classes, which results in many of these
tests being ran multiple times needlessly. This change removes the
base TestCase unit test class from LDAPIdentity, which is inherited
by multiple other test classes.

Change-Id: Iee0a0942e49295081437306d3942109c4132b704
Partial-Bug: #1373865
This commit is contained in:
Gage Hugo 2017-09-26 17:05:39 -05:00
parent 13280c25bf
commit de9546b4ef
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
keystone/tests/unit/test_backend_ldap.py
View File

@ -1040,7 +1040,7 @@ class BaseLDAPIdentity(LDAPTestSetup, IdentityTests, AssignmentTests,
self).test_remove_foreign_assignments_when_deleting_a_domain)
class LDAPIdentity(BaseLDAPIdentity, unit.TestCase):
class LDAPIdentity(BaseLDAPIdentity):
def assert_backends(self):
_assert_backends(self,
@ -1769,7 +1769,7 @@ class LDAPLimitTests(unit.TestCase, identity_tests.LimitTests):
return config_files
class LDAPIdentityEnabledEmulation(LDAPIdentity):
class LDAPIdentityEnabledEmulation(LDAPIdentity, unit.TestCase):
def setUp(self):
super(LDAPIdentityEnabledEmulation, self).setUp()
_assert_backends(self, identity='ldap')