openstack
/
keystone
Code Issues Proposed changes

Remove obsolete note from ldap 

There was a note in the ldap assignment backend about normalizing
a DN using .upper(). This note is obsolete with the recent change
to use a DN compare function.

Change-Id: I34c69573498b5f2d2103ea485160df421c6f2b03
Related-Bug: #1309228
This commit is contained in:
Brant Knudson 2014-05-23 15:44:05 -05:00
parent ace80725fe
commit f0eee2f3b4
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
keystone/assignment/backends/ldap.py
View File

@ -98,12 +98,6 @@ class Assignment(assignment.Driver):
def _get_roles_for_group_and_project(group_id, project_id):
self.get_project(project_id)
group_dn = self.group._id_to_dn(group_id)
# NOTE(marcos-fermin-lobo): In Active Directory, for functions
# such as "self.role.get_role_assignments", it returns
# the key "CN" or "OU" in uppercase.
# The group_dn var has "CN" and "OU" in lowercase.
# For this reason, it is necessary to use the "upper()"
# function so both are consistent.
return [self.role._dn_to_id(a.role_dn)
for a in self.role.get_role_assignments
(self.project._id_to_dn(project_id))