openstack
/
kuryr-tempest-plugin
Code Issues Proposed changes

Namespace tests: use requests instead of subprocess 

Use requests instead subprocess in namespace tests

Change-Id: Iba2d3f5bbad56e5306260d2eb673e6974703e3ee
Signed-off-by: Antoni Segura Puimedon <celebdor@gmail.com>
This commit is contained in:
Antoni Segura Puimedon 2018-08-10 12:23:05 +02:00 committed by Yossi Boaron
parent 1757750452
commit d9f7f96c9a
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
kuryr_tempest_plugin/tests/scenario/test_namespace.py
View File

@ -13,14 +13,12 @@
# limitations under the License.
import kubernetes
import shlex
import subprocess
import requests
import time
from oslo_log import log as logging
from tempest import config
from tempest.lib import decorators
from tempest.lib import exceptions as lib_exc
from kuryr_tempest_plugin.tests.scenario import base
from kuryr_tempest_plugin.tests.scenario import consts
@ -83,13 +81,7 @@ class TestNamespaceScenario(base.BaseKuryrScenarioTest):
self.wait_service_status(svc_service_ip,
CONF.kuryr_kubernetes.lb_build_timeout)
cmd = "curl {dst_ip}".format(dst_ip=svc_service_ip)
try:
subprocess.check_output(shlex.split(cmd))
except subprocess.CalledProcessError:
LOG.error("Checking output of curl to the service IP %s "
"failed" % svc_service_ip)
raise lib_exc.UnexpectedResponseCode()
requests.get(svc_service_ip)
# Check resources are deleted
self._delete_namespace_resources(namespace_name, kuryr_net_crd,