openstack
/
magnum
Code Issues Proposed changes

Remove redundant commas 

Some commas, for example the last comma in
def test_create_container(self, mock_container_create,) are redundant,
so we should remove it.

Change-Id: If3127d17df2ff2a40b0bfc98c504f1ff751c6bf0
Closes-Bug: 1476899
This commit is contained in:
Hua Wang 2015-07-14 23:29:10 +08:00
parent fe0c382bfa
commit 6685d118af
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
magnum/tests/unit/api/controllers/v1/test_container.py
View File

@ -36,7 +36,7 @@ class TestContainerController(db_base.DbTestCase):
self.mock_baymodel_get_by_uuid.return_value.coe = 'swarm'
@patch('magnum.conductor.api.API.container_create')
def test_create_container(self, mock_container_create,):
def test_create_container(self, mock_container_create):
mock_container_create.side_effect = lambda x, y, z: z
params = ('{"name": "My Docker", "image": "ubuntu",'
@ -135,7 +135,7 @@ class TestContainerController(db_base.DbTestCase):
self.assertTrue(mock_container_create.not_called)
@patch('magnum.conductor.api.API.container_create')
def test_create_container_invalid_long_name(self, mock_container_create,):
def test_create_container_invalid_long_name(self, mock_container_create):
# Long name
params = ('{"name": "' + 'i' * 256 + '", "image": "ubuntu",'
'"command": "env",'

2
magnum/tests/unit/common/test_utils.py
View File

@ -176,7 +176,7 @@ exit 1
'correctly')
runs = int(runs.strip())
self.assertEqual(10, runs,
'Ran %d times instead of 10.' % (runs,))
'Ran %d times instead of 10.' % runs)
finally:
os.unlink(tmpfilename)
os.unlink(tmpfilename2)