Sometimes b32decode may generate data which can't be decoded.
Ignore UnicodeDecodeError so that a few other formats can be tried.
Closes-bug: #2043572
Change-Id: I5d978e8eb3931a218b1946625baa28aa23890cd6
The current shebang requires /usr/bin/python which is not available in
Ubuntu Jammy by default.
This also removes unnecessary shebangs.
Change-Id: I046542e43d993ba201cc035554b4dcc4d364ed0a
The wsgi.input environment variable is expected to be a stream
instead of a string.
Closes-Bug: #2034952
Change-Id: I72e88dcf07c90051ddf1c9030a2466501482de5d
Almost all selectors in dashboard forms add empty string as option. It
is ok for non-required fields, but invalid for required fields like
"Share Group type" at "Share Group create" form. Proposed patch removes
this empty string where it is invalid
Change-Id: I0eef44eec858dfbf287930a7d318fb1570450e3c
Previously "Set as Active" button was displayed during replicas in
transitional states such as deleting or replication change which
is fixed with this patch.
Closes-Bug: #1624425
Change-Id: I32ecf22ce1df0a752d0e66f989ad15fd776e4175
Patch fixes switching on of Share Network widget for share types with
upper-case letters in their name
Change-Id: I3422d9b17159e2a3c5b7df859f797413962afca2
Address the issue by ensuring that the boolean value of extra
specs or metadata being read are from string type. If they are
not, we convert them before getting the length.
Closes-Bug: #2004165
Change-Id: I96c7a6bf862ad81ed756f16f0c398ce68bcf5e66
Currently, only the name and public access of share-type is set when the
share-type is created, and not allowed to be edited after the share-type
is created. We can only set extra spec for share-type. This commit
suppport update name,description or public access of share-type.
Change-Id: Ia59ae574482fa8015f0151cd983ef880e180640a
Partially-Implements: blueprint update-share-type-name-or-description
The manilaclient SDK not accept a "share_network"
argument anymore with the share_replicas.create()
method.
Change-Id: If21408291fcb4ccd778b24145effcb253227df55
Closes-Bug: #1968925
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
In Django 3.0 ugettext_lazy/ungettext_lazy have been deprecated in favor of
gettext_lazy/ngettext_lazy [0].
We are now using Django 3.2, so we should update our code
with the gettext_lazy/ngettext_lazy aliases.
[0] https://docs.djangoproject.com/en/3.0/releases/3.0/#id3
Closes-Bug: #1956220
Change-Id: I488c2230b4ea4e7803522c3b99773cffe76f49bd
python-manilaclient 3.3.0 [1] has a bug that causes the shares
panel to fail to load with an error:
Error: Unable to retrieve share list. Details
'NoneType' object has no attribute 'pop'
Workaround this problem so we don't have to add the client
version to a block-list in the UI's requirements files.
Closes-Bug: #1967312
[1] https://pypi.org/project/python-manilaclient/3.3.0/
Change-Id: I9e79972d9aca4fc7845f4d274751351d948f41ef
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
In Django 3.1 url has been deprecated in favor of
re_path [0]
We are now using Django 3.2, so we should update our
code with the re_path alias.
This has been fixed in Horizon as well [1]
[0] https://docs.djangoproject.com/en/4.0/releases/3.1/#id2
[1] d9266fd82c
Closes-Bug: #1967172
Change-Id: Ibb5d5b726a836738b616e42f2cd9c6ee49835e0f
Follow up to change #783041. Fixes bug of missing "share_id"
argument in redirection url in Exception case.
Change-Id: Iaadf24c839296e44c51dd1da2399bb63f757829a
Added 'is_default' field to share types and share group
types list. 'is_default' field will show Yes if the share type
or share group type is default.
Partial-Bug: #1823078
Change-Id: I923cb2ae90612fb8d5d3af467654a71b83266ffc
Added access metadata for share access and also introduced the GET /share-access-rules API.
The prior API to retrieve access rules will not work with API version >=2.45
Closes-Bug: #1920687
Change-Id: Iec3a3fad5e2bdf854f04ae974248d899f90bd894
This patch-set modifies how we manage user input when creating a share
from snapshot. Since we use the same form for the basic create share workflow
and for the create share from snapshot workflow, we need to add a check
to distinguish both cases: when creating a share from snapshot, the
parent share availability zone is picked by default. Otherwise, if it's a
regular share create, the user can pick up the availability zone they need.
Closes-Bug: #1915706
Change-Id: I8d93c2214cb187a763df861555ddd7b444c9ca89
A recent change [1] introduced an encoding for
problematic field names. On the share group
creation form, an encoding was missed causing
a silent failure where the share type/s chosen
were ignored in the API request.
[1] 37e5b2f053
Change-Id: I0983359acc489513a5a0940ac379e0a078870548
Partial-Bug: #1931641
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
In the share creation form dialog, share network
selection is optionally provided based on whether
the share type chosen supports the DHSS extra-spec.
This selection breaks often when dealing with share
types that have a name matching the format: ".*-\d+.*".
For example: test-700. The root cause of this seems to
be in javascript code for "switchable" fields [1] that
doesn't get triggered as expected.
A similar issue manifests in the share Network Creation
form where we setup switched fields with the Neutron
network IDs (dashed format UUIDs) and in the Share
Group Creation form where we setup switched fields
with the Share Group Type IDs (dashed format UUIDs).
So, we could encode the "-" in these field names to
workaround this issue.
Closes-Bug: #1931641
[1] 647c2b7530/horizon/static/horizon/js/horizon.forms.js (L491-L613)
Change-Id: Id924fc55debdc38ae2131bf8cef396f28caa3e77
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This is essentially dead code elimination
from manila-ui at this point since manila
and python-manilaclient dropped support
in the Ocata release.
Change-Id: I92e87282020047c7fad055cae92f2382c4193597
Partially-implements: bp remove-nova-net-plugin
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This change adds support for policy-in-code and deprecated policy
following the change in horizon.
Depends-on: https://review.opendev.org/750134
Change-Id: I408af56e6a54b135d38a486101b4bb3108d4f0d5
Added 'ou' field to security service field. Also, 'description'
field was added to display in both project and admin module.
Options to update dns_ip, ou, server, domain, password and
user fields were added as well. As this options are available
for command line interface.
Partial-Bug: #1823078
Change-Id: I03c0cb01cc04745e67d94a45e3f7570c1609ede0
This change demonstrates how we can define logging setting specific to
manila-ui, so that operators can easily understand how to customize
logging level and so on.
Change-Id: Ia8505d988ed75e0358452b5b3c2889b364680f22
Currently, share shrinking feature in Manila-UI is not supported.
Only "Extend Share" feature exists. "Extend Share" feature was
renamed as "Resize Share" and share shrinking feature was added.
Now it works both ways, if value in "New Size" field is less than
original size, it will shrink, and if value is more it will extend.
Also, minimal value was added to "New Size" field to ensure the
value doesn't decrease to zero.
Implements: blueprint share-shrinking
Change-Id: I8553bed01b529c1b3a57b1e900d171db1d5f28d2
In Python 3, all strings are represented in Unicode.In Python 2 are
stored internally as 8-bit ASCII, hence it is required to attach 'u'
to make it Unicode. It is no longer necessary now.'
Change-Id: Ib739730cf74a880fc07f0279f55dd00e9c003465