openstack
/
manila
Code Issues Proposed changes

INFINIDAT: suppress 'no-member' pylint errors 

The INFINIDAT 'infinisdk' module uses the 'capacity' module to describe
capacity sizes (as similar to the 'oslo_units' module). As the module
might not be present in its testing environment, pylint has a hard time
recognizing some of the module's members. This change suppresses the
pylint errors only where needed, as the 'capacity' module is used only
in very specific methods in the driver.

Change-Id: Ife41e05c743a8f21ff2a91c0c3b9999b1cc25245
Closes-Bug: #1816646
This commit is contained in:
Amit Oren 2019-03-21 16:40:05 +02:00
parent 0920f60bc9
commit 1beaf63579
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manila/share/drivers/infinidat/infinibox.py
View File

@ -174,6 +174,7 @@ class InfiniboxShareDriver(driver.ShareDriver):
super(InfiniboxShareDriver, self)._update_share_stats(data)
def _get_available_capacity(self):
# pylint: disable=no-member
pool = self._get_infinidat_pool()
free_capacity_bytes = (pool.get_free_physical_capacity() /
capacity.byte)
@ -182,6 +183,7 @@ class InfiniboxShareDriver(driver.ShareDriver):
provisioned_capacity_gb = (
(pool.get_virtual_capacity() - pool.get_free_virtual_capacity()) /
capacity.GB)
# pylint: enable=no-member
return (free_capacity_bytes, physical_capacity_bytes,
provisioned_capacity_gb)
@ -368,7 +370,9 @@ class InfiniboxShareDriver(driver.ShareDriver):
@infinisdk_to_manila_exceptions
def _extend_share(self, infinidat_filesystem, share, new_size):
# pylint: disable=no-member
new_size_capacity_units = new_size * capacity.GiB
# pylint: enable=no-member
old_size = infinidat_filesystem.get_size()
infinidat_filesystem.resize(new_size_capacity_units - old_size)
@ -389,7 +393,7 @@ class InfiniboxShareDriver(driver.ShareDriver):
self._verify_share_protocol(share)
pool = self._get_infinidat_pool()
size = share['size'] * capacity.GiB
size = share['size'] * capacity.GiB # pylint: disable=no-member
share_name = self._make_share_name(share)
infinidat_filesystem = self._system.filesystems.create(