openstack
/
monasca-agent
Code Issues Proposed changes

Fix log rotation in monasca agent 

Observed AttributeError in forwarder and collector logs due to
missing import of logging module handlers.

Added missing import and removed module level import.

Task:15058
Story: 2001941
Change-Id: I62b03bb550c8b01ce9ea5bb4ba49a2ac00763d68
This commit is contained in:
Jui Chandwaskar 2018-04-30 11:21:45 +02:00
parent 2b2b5719c7
commit 82200d9401
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
monasca_agent/common/util.py
View File

@ -31,6 +31,7 @@ import traceback
import uuid
import logging
import logging.handlers
from numbers import Number
@ -637,7 +638,6 @@ def initialize_logging(logger_name):
try:
syslog_format = '%s[%%(process)d]: %%(levelname)s (%%(filename)s:%%(lineno)s): ' \
'%%(message)s' % logger_name
from logging.handlers import SysLogHandler
if logging_config['syslog_host'] is not None and logging_config[
'syslog_port'] is not None:
@ -648,7 +648,8 @@ def initialize_logging(logger_name):
if sys.platform == 'darwin':
sys_log_addr = "/var/run/syslog"
handler = SysLogHandler(address=sys_log_addr, facility=SysLogHandler.LOG_DAEMON)
handler = logging.handlers.SysLogHandler(
address=sys_log_addr, facility=logging.handlers.SysLogHandler.LOG_DAEMON)
handler.setFormatter(
logging.Formatter(syslog_format, log_date_format))
root_log = logging.getLogger()