This is to address another usage of base64 that was missed from
commit 794c47f3b8823e97a0f019064e4b74a5ee204d04
Change-Id: I9bbff8084d82928deeafa6a55c487ed0f665b470
Murano Agent uses default folder permissions for the
execution plans and scripts. If the default is too permissive
(which is unusual), other users on that machine can trick
the agent to execute malicious execution plans by putting files
into queue folder and use it to get the root privileges.
In most common sense users won't have write permissions to murano-agent
folders. However, they can hijack execution plans and other data
that might contain sensitive information.
This commit sets 0700 mode to the agent runtime folders so that they
can be accessed only by the user that runs the agent (+ the root,
if it's someone else).
Change-Id: I27f0495a509c4d1435d630e2bc5bfdf3549486d5
Run the sixer program to catch most common Python 3 issues and make
the code compatible with Python 2 and Python 3.
* Replace it.next() with next(it)
* Replace dict.keys()[0] with list(dict.keys())[0], since
dict.keys() now returns an dictview on Python 3. Same change
for dict.values()[0].
* Replace urlparse with six.moves.urllib.parse
* Replace __builtin__ with six.moves.builtins
Blueprint: murano-python-3-support
Change-Id: I9b95c3eee14c2de0010e9a3bbdffdda76496a03c
When cookbooks are transfered from murano to
murano-agent, they are stored in another folder
which chef/puppet expect.
Closes-Bug: #1508492
Change-Id: I1363e46d655c8a641a1fa404faadc5f652f9fce4
The clear() method is calling rmtree() to delete cache folder
but the call is being made twice. The second call is unnecessary.
Change-Id: I78b0ed2417b3775604816bf078abedce79406edd
Closes-Bug: #1513010
Murano agent can download files in the VM when it is executing the
execution plan. However, just git client is allowed for download
files. Svn client should be provided to add files in a svn repository
Closes Bug: #1486055
Change-Id: Ib1fd13fa86d012fb95d19aabda0dff7c28f99620
Use oslo.log instead of oslo-incubator.
Use oslo.log instead of system logging.
Add oslo.log to the requirements.txt.
Remove unused oslo-incubator modules.
Implements: blueprint port-oslo-incubator-to-oslo-log
Partial-Bug: 1481370
Change-Id: I7047497f2022b0c56be0f3811f1bb59ffe470877
Manually updating the requirements, since this project isn't in
the list getting requirements syncs from global requirements. Updating
hacking required some format changes to docstrings, and I included those
in this patch.
Change-Id: Ib33f6308ed121fa2350eb32846e476f2a9dd28f4
When there is a downloadable type file which is a git repository,
a folder not found error appears: No such file or directory
Also updated unit tests to work on Windows
Closes Bug: #1444862
Change-Id: I5ebb01b8d2c324e4e603a90142433b2abbbd62a2
Incorrect generation of file path where to put script symlink caused
"OSError: [Errno 2] No such file or directory" exception to be raised
after first execution plan run
Change-Id: I955d01deb8ff4bb5ddf8a39340cbe4439bb8311a
Closes-Bug: #1439767
It allows for Puppet as configuration language in the execution plans.
In addition, it creates a base class (ChefPuppetExecutorBase) for
sharing common methods between Puppet and Chef executors.
Change-Id: I65ae656117aa26fc7dff4f83a2be1b4d2c3cb58b
[DIB] Add posibility to build image from specified commit of agent
Included gitpython, required by file-downloading feature
Incorrect generation of file path where to put script symlink caused
"OSError: [Errno 2] No such file or directory" exception to be raised
after first execution plan run
Change-Id: Ifb6dffde5afd5ad5ce363934be71c7cc1e046de2
Closes-Bug: #1439367
Closes-Bug: #1439767
Co-Authored-By: Stan Lagun <slagun@mirantis.com>
Co-Authored-By: Kirill Zaitsev <kzaitsev@mirantis.com>
Execution plan files can be tranfered as binaries as just an URL to be download.
This code download the file when it is a URL
Partially-Implements Blueprint: conf-language-support
Change-Id: I102546a04a93dc74a4647cc8ad7a33d78ebca86b
* Add scripts for generation sample configs
* Fix name in setup.cfg, otherwise module is not recognized
* Add check to pep8 to follow new config parameters
Change-Id: I42918abc7fdcf9c6779c4e97ba7f2b605b9057e8
Andy Botting