openstack
/
murano-dashboard
Code Issues Proposed changes

Fix create environment TypeError 

Now create environment give the error:
TypeError: get_form() takes exactly 2 arguments (1 given)

This patch fix this.

Change-Id: I4833b9c13249d547a91f13094b5764f788014dfb
Closes-Bug: #1703174
This commit is contained in:
zhurong 2017-07-09 16:08:30 +08:00
parent 53c892e342
commit ecb019b58b
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
muranodashboard/environments/views.py
View File

@ -174,9 +174,10 @@ class CreateEnvironmentView(views.ModalFormView):
submit_url = reverse_lazy(
'horizon:app-catalog:environments:create_environment')
def get_form(self, form_class):
def get_form(self, **kwargs):
if 'next' in self.request.GET:
self.request.session['next_url'] = self.request.GET['next']
form_class = kwargs.get('form_class', self.get_form_class())
return super(CreateEnvironmentView, self).get_form(form_class)
def get_success_url(self):

2
muranodashboard/tests/unit/environments/test_views.py
View File

@ -271,7 +271,7 @@ class TestCreateEnvironmentView(testtools.TestCase):
@mock.patch('muranodashboard.environments.forms.net')
def test_get_form(self, mock_net):
mock_net.get_available_networks.return_value = None
form = self.create_env_view.get_form(self.create_env_view.form_class)
form = self.create_env_view.get_form()
self.assertIsInstance(form, env_forms.CreateEnvironmentForm)
self.assertEqual('next_foo_url',