Commit Graph

5 Commits

Author SHA1 Message Date
zhurong ed344e55aa Update murano-dashboard eslint devDependencies
Synchronize the eslint and eslint-config-openstack versions with horizon.

Change-Id: I117d1e5e418183cc72048a889acbd825a240cfe0
2016-09-21 11:27:26 +08:00
Kirill Zaitsev 0996aa1f2d eslint cleanup of draggable-components.js
Cleanup draggable-components.js to pass eslint.

Added checks, that Hogan templates are present on the page, to prevent
occasional failures if the script is included on a different page.
Refactored prototype modification.
Added TENANT_ID to global variables in .eslintrc

Partially implements: blueprint add-js-lint-jobs

Change-Id: I35e3cee2af3eb8ee34f4b9a97cd9e4e756cd6458
2015-07-30 19:08:50 +03:00
Kirill Zaitsev 0f6186b231 Adopt openstack-config for eslint
Since openstack-config for eslint is now published on npm we should use
it as basis for our linting rules. It is actually stricter, than our
current semi-default config as it enables some of the previously
unchecked rules.

Partially implements: blueprint add-js-lint-jobs

Change-Id: I0cb8247167a44f30a657693442f99a87f116350a
2015-07-29 00:43:24 +03:00
Kirill Zaitsev a21d86b068 eslint cleanup of smaller js files
Added indentation check to .eslintrc
Cleaned up horizon.tables+reload.js, mixed-mode.js, submit-disabled.js,
upload_form.js, according to eslint rules.
Added missing license info to horizon.tables+reload.js

Partially implements: blueprint add-js-lint-jobs

Change-Id: If417405c24eaa0c65b8093e559730e83bd070b57
2015-07-24 03:56:10 +03:00
Kirill Zaitsev 886807c337 Add eslint javascript checker
This commit adds a eslint tox environment, that installs eslint and
checks muranodashboard js code against it.

Eslint is the current linter of choice for horizon, because it is
capable of detecting both style and syntax errors (and does not have
license limitations of jshint).

To run: tox -e eslint
Partially implements: blueprint add-js-lint-jobs

Change-Id: I645f279ab6ac45b7d1d872ded803c126dd0a10e7
2015-07-13 13:57:50 +03:00