openstack
/
murano
Code Issues Proposed changes

Remove the wrong assert_is_called checking 

Remove the assert_is_called checking, because It is incorrect and is not necessary.

Change-Id: I1bbb5234d9c6d009691bce919435dffbefbdd023
Closes-Bug: #1473369
This commit is contained in:
Sergey Vilgelm 2015-07-10 12:12:14 +03:00 committed by Kirill Zaitsev
parent 578a0124ae
commit 7aad079e9d
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
murano/tests/unit/db/services/test_core_service.py
View File

@ -35,7 +35,6 @@ class TestCoreServices(base.MuranoTestCase):
fixture.environment_template_desc
template_des = self.core_services.get_template_data('any', '/services')
self.assertEqual(template_des, [])
template_services_mock.get_description.assert_is_called()
template_services_mock.get_description.assert_called_with('any')
@mock.patch('murano.db.services.environment_templates.EnvTemplateServices')
@ -47,7 +46,6 @@ class TestCoreServices(base.MuranoTestCase):
fixture_env_apps.env_template_desc
template_des = self.core_services.get_template_data('any', '/services')
self.assertEqual(template_des, fixture_apps.applications_desc)
template_services_mock.get_description.assert_is_called()
template_services_mock.get_description.assert_called_with('any')
@mock.patch('murano.db.services.environment_templates.EnvTemplateServices')
@ -61,7 +59,6 @@ class TestCoreServices(base.MuranoTestCase):
self.core_services.get_template_data('any',
'/services/tomcat_id')
self.assertEqual(template_des, fixture2.application_tomcat_desc)
template_services_mock.get_description.assert_is_called()
template_services_mock.get_description.assert_called_with('any')
@mock.patch('murano.db.services.environment_templates.EnvTemplateServices')
@ -76,9 +73,7 @@ class TestCoreServices(base.MuranoTestCase):
fixture2.env_template_desc,
'/services')
self.assertEqual(template_des, fixture2.env_template_desc)
template_services_mock.get_description.assert_is_called()
template_services_mock.\
get_description.assert_called_with('any')
template_services_mock.get_description.assert_called_with('any')
@mock.patch('murano.db.services.environment_templates.EnvTemplateServices')
def test_template_delete_services(self, template_services_mock):
@ -92,9 +87,7 @@ class TestCoreServices(base.MuranoTestCase):
'/services/54aaa43d-5970')
template_des = self.core_services.get_template_data('any', '/services')
self.assertEqual(template_des, [fixture.application_tomcat_desc])
template_services_mock.get_description.assert_is_called()
template_services_mock.\
get_description.assert_called_with('any')
template_services_mock.get_description.assert_called_with('any')
@mock.patch('murano.db.services.environment_templates.EnvTemplateServices')
def test_get_template_no_exists(self, template_services_mock):
@ -106,9 +99,7 @@ class TestCoreServices(base.MuranoTestCase):
self.assertRaises(exc.HTTPNotFound,
self.core_services.get_template_data,
'any', '/services/noexists')
template_services_mock.get_description.assert_is_called()
template_services_mock.\
get_description.assert_called_with('any')
template_services_mock.get_description.assert_called_with('any')
@mock.patch('murano.db.services.environment_templates.EnvTemplateServices')
def test_adding_services(self, template_services_mock):
@ -130,5 +121,4 @@ class TestCoreServices(base.MuranoTestCase):
template_des = \
self.core_services.get_template_data('any', '/services')
self.assertEqual(template_des, fservices.applications_desc)
template_services_mock.get_description.assert_is_called()
template_services_mock.get_description.assert_called_with('any')