openstack
/
neutron-fwaas-dashboard
Code Issues Proposed changes

firewall group table: fix handling of ports of FWG 

The previous code assumes a list of api.neutron.Port objects
as FWG.ports but actually FWG.ports is a list of UUID.
It seems to come from copy-and-paste of FWaaS v1 code without testing.

This commit changes a value to be displayed from name/ID of ports
to the number of ports. A list of ports can be long and it is not
a good idea to show all ports in the firewall group table.
I believe the number of associated ports makes more sense.

Change-Id: I0fc7a41e7aaac3fdb305fb7ccdae466f7cbdf56f
Closes-Bug: #1747524
(cherry picked from commit 47a83bdc68)
This commit is contained in:
Akihiro Motoki 2018-02-06 06:51:27 +09:00
parent 2d5ab204e5
commit 90678160af
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron_fwaas_dashboard/dashboards/project/firewalls_v2/tables.py
View File

@ -254,7 +254,7 @@ def get_rules_name(datum):
def get_ports_name(datum):
return ', '.join([port.name_or_id for port in datum.ports])
return len(datum.ports)
def get_ingress_policy_link(datum):