The ugettext_lazy method and the ungettext_lazy method are both
deprecated since Django 3.0[1].
These were already replaced in Horizon repo by [2].
[1] https://docs.djangoproject.com/en/3.0/releases/3.0/#id3
[2] cd7c1b5110fe1f64cd9dfbeb1072b37912d0efee
Change-Id: If17fba432f4a00979f70b535bc1f1750d8a15f19
The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.
Change-Id: I72feb6bdcee015029beb274b57600e3e5b4b9ed9
This patch adds basic tests to verify that neutron-fwaas-dashboard
is installed and could be opened.
Also this patch decoupless sphinx vesrions for Python 2.7 and 3.x
to fix gates.
neutron-fwaas-dashboard job is added in a non-voting mode.
Change-Id: I1dca0bfbdc44186fffcbe757a142c930f5bc14b4
As seen here [1].
When a corresponding field has no selection, an empty string is
passed to the server. This change replaces None with an empty string.
After this change, all tests pass with Django 2.2,
so we can make django22 job voting.
[1] https://github.com/django/django/commit/6fe9c45b725
Change-Id: I4cd551253ac361eaa46b6de35369125eb0e20e98
Changes the signature of the custom TableSelectWidget to be compatible
with Django 2.2.
Change-Id: Ic77917fca514ef3686131a051cc2474ec9fcc8bd
closes-bug: 1843701
By default, the admin state of a new firwall group should be UP.
This patch mark the checkbox.
Change-Id: Id377c656788e0fbb13c4b8f90dd022e39c50adbf
Closes-bug: #1833374
This commit adds a new customizable Django/Horizon widget which displays
Select options as table without adding AngularJS components or new
custom JS code.
The widget is then used to display port information in the dialogs used
for port adding to, and removing from, Firewall Groups.
Change-Id: I9707179557919643d4432d8ed29f2c80e44e6af4
Closes-Bug: #1810391
DetailTabsGroup class is prepared to have a good margin
between a tab bar and the detail information in detail pages.
Previously we have no margin between the tab bar and the detail
information in the firewall group detail page. The issue can be
addressed by using DetailTabsGroup.
Change-Id: Ic7a1ca388812ae5759c9c4c9edbc4f5793a70a35
ingress/egress_firewall_policy_id of a firewall group can be null.
Previously the firewall group detail page always create a link
even when ingress/egress_firewall_policy_id is null and it leads
to an invalid link.
Change-Id: I491482789385e9d9735ebcafcc5574fc11fdd2ac
This commit cleans up usage of 'firewall' (in favor of
'firewall group') in the API wrapper layer and messages.
Change-Id: Icf496933ebfd00eac15e24c9c15249c4d18d86de
Partial-Bug: #1723952
Previously devstack/plugin.sh mirrors POLICY_FILES in horizon repo
but this is not a good idea because we must catch up with changes
in horizon.
This commit prepares a local_settings.d file for neutron-fwaas-dashboard
to setup POLICY_FILES entry for the dashboard.
Change-Id: I45d8e8a27f70708f701ec84559d9af40561dd549
As of horizon 14.0.0.0b2 or later the use_mox directive is unecessary
so we can remove it.
Change-Id: I1191bb4223556b7da1f4377bec70277abf58dd39
Signed-off-by: Chuck Short <chucks@redhat.com>
We're going to switch to default Django test runner by default.
This patch renames test files to make tests descoverable by
Nose and Django test runners without addidional configuration.
Related blueprint: improve-horizon-testing
Change-Id: I16022a448139958905746cc37520c345b48d6970
APIDictWrapper provides to_dict() method, so there is no need
to have get_dict() method in Firewall wrapper API classes.
firewalls_v2.views.RouterCommonView is also unnecessary
as this is not used anywhere.
Change-Id: I760d653aa2404f574755572a90bfcd2bbad9a7bf
Closes-Bug: #1723951
Pep8 job is broken due to recent pep8 upgrade and corresponding
pycodestyle update.
This commit fixes the following errors:
- E402 module level import not at top of file
Change-Id: I0e6c31c6e8edd6994854f98d898ee897c91dd140
Replace django.core.urlresolves with django.urls
(In Django 2.0) The django.core.urlresolvers module is removed
in favor of its new location, django.urls.
It was depreacted in Django 1.10:
https://docs.djangoproject.com/en/2.0/releases/1.10/#id3
Add py35dj20 job to test Django 2.0 integration.
Also drops py27dj110 from tox.ini as horizon droped
Django 1.10 support in Rocky.
blueprint django2-support
Change-Id: I8e0dcb64e1c82580767db482631450ba38654fc3
create_stubs in test.helpers is also dropped in this commit
because this creates a stub using mox.
This is part of mox-removal community goal in Rocky.
lower-constraints.txt are updated to pass requirements-check
as this file is updated automatically now and we need to update
it when updating this file from some reasons.
Change-Id: Ib4c7c3003ce5d895c9c514aa0af6491da1667891
Closes-Bug: #1753504
Previously expected PUT data for update tests were completely wrong.
I don't know why the previous mox unit tests pass. After switching to
mock, they no longer can pass and this commit fixes them.
This patch also clean up unnecessary mocked methods.
This is part of mox-removal community goal in Rocky.
Partial-Bug: #1753504
Change-Id: I135b1745c933deca37d17e6af250e16aabf912e7
Note that test_add_firewall_post_with_router_extension() is also fixed
because we need to post unassociated router IDs to the form of creating
a new firewall but the previous test sends associated router ID.
This fix is required to pass the test after mock is used.
I am not sure why the test succeeded with mox though....
Also cleans up unnecessary mocked methods.
This is part of mox-removal community goal in Rocky.
Partial-Bug: #1753504
Change-Id: I033421aeb00d97c049bec3d04da6989c811d1514
SelectRoutersStep.contributes contains non-existing fields
"all_routers_selected" and "Select No Routers".
It is confusing for future maintenance. Let's drop them.
Change-Id: Ie4f710f28328623d1bd56d6298fd638615f6a14f
Takashi Kajinami