Use flake8-import-order plugin

Automate the process. By using flake8-import-order plugin, we can avoid
this. It enforces loose checking so it sounds good to use it.

Note that flake8-import-order version is pinned to avoid unexpected
breakage of pep8 job.

Change-Id: I8585568761395ed83cf123141ac7931a3707ad5f

neutron_fwaas/__init__.py

@@ -14,6 +14,7 @@
 #    under the License.
 
 import gettext
+
 import six
 
 

neutron_fwaas/extensions/firewall_v2.py

@@ -13,6 +13,7 @@
 # under the License.
 
 import abc
+
 from neutron.api.v2 import resource_helper
 from neutron_lib.api import converters
 from neutron_lib.api import extensions

neutron_fwaas/tests/unit/services/firewall/drivers/linux/test_iptables_fwaas.py

@@ -14,10 +14,11 @@
 #    under the License.
 
 import copy
-import mock
 
+import mock
 from neutron.tests import base
 from neutron.tests.unit.api.v2 import test_base as test_api_v2
+
 import neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas as fwaas
 
 

neutron_fwaas/tests/unit/services/firewall/drivers/linux/test_iptables_fwaas_v2.py

@@ -14,10 +14,11 @@
 #    under the License.
 
 import copy
-import mock
 
+import mock
 from neutron.tests import base
 from neutron.tests.unit.api.v2 import test_base as test_api_v2
+
 import neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas_v2 as fwaas
 
 

neutron_fwaas/tests/unit/services/firewall/test_fwaas_plugin.py

@@ -13,18 +13,23 @@
 #  License for the specific language governing permissions and limitations
 #  under the License.
 
-import mock
-import testtools
+import uuid
 
+import mock
 from neutron.api import extensions as api_ext
 from neutron.common import config
 from neutron.tests.common import helpers
 from neutron.tests import fake_notifier
 from neutron.tests.unit.extensions import test_agent
 from neutron.tests.unit.extensions import test_l3 as test_l3_plugin
+from neutron_lib.api import attributes as attr
+from neutron_lib import constants as nl_constants
+from neutron_lib import context
+from neutron_lib.plugins import constants as plugin_constants
+from neutron_lib.plugins import directory
 from oslo_config import cfg
 import six
-import uuid
+import testtools
 from webob import exc
 
 from neutron_fwaas.db.firewall import firewall_db as fdb
@@ -36,12 +41,6 @@ from neutron_fwaas.tests import base
 from neutron_fwaas.tests.unit.db.firewall import (
     test_firewall_db as test_db_firewall)
 
-from neutron_lib.api import attributes as attr
-from neutron_lib import constants as nl_constants
-from neutron_lib import context
-from neutron_lib.plugins import constants as plugin_constants
-from neutron_lib.plugins import directory
-
 extensions_path = neutron_fwaas.extensions.__path__[0]
 
 FW_PLUGIN_KLASS = (

test-requirements.txt

@@ -5,6 +5,7 @@ hacking!=0.13.0,<0.14,>=0.12.0 # Apache-2.0
 
 coverage!=4.4,>=4.0 # Apache-2.0
 fixtures>=3.0.0 # Apache-2.0/BSD
+flake8-import-order==0.12 # LGPLv3
 mock>=2.0 # BSD
 python-subunit>=0.0.18 # Apache-2.0/BSD
 requests-mock>=1.1 # Apache-2.0

tox.ini

@@ -96,6 +96,7 @@ ignore = E125,E126,E128,E129,E265,H404,H405,N530,N537
 enable-extensions=H904
 show-source = true
 exclude = .venv,.git,.tox,dist,doc,*lib/python*,.tmp,*egg,build,tools,.ropeproject,rally-scenarios
+import-order-style = pep8
 
 [testenv:pylint]
 deps =