While NLBaaS member is an invalid state, the shown error message doesn't
give enough info to resolve the problem.
Change-Id: Ia18958d6f7126b46eae33ee615a18b34e3b76357
When a user associated a VIP to his own security group, the migration
should not change its ownership.
Change-Id: I74648fc016f490c83890568fdd482ef0fdd8fa61
The word "key" is reserved in SQL. lbaas_l7rules table has a field
name "key" which using it unescaped raises a mysql exception.
Change-Id: Ic0ddc86fe361014972f2a728beb3e8a3ed20e785
This patch adds a tool that migrates running load balancers from Neutron-LBaaS
to Octavia.
It also creates a periodic test to run the migration tool.
Story: 1640526
Task: 5161
Task: 22605
Change-Id: I541f84fffe26af8ff49f8cb05733ef4018a89dbd
Switch tox.ini to directly call stestr instead of
testrepository which is not maintained.
Also skip a problematic test temporarily until we can resolve the larger
gate issues.
Co-Authored-By: Adam Harwell <flux.adam@gmail.com>
Change-Id: Icf1f9eb4539666dffb6c9c1651670541523a9f9e
This removes the newton jobs no longer needed, removes the tripleo-elements
that we no longer use, and sets up py3x jobs for stable/pike
Depends-On: I782e6d6fb6e575c00644f72602bc90a3d25bc18c
Change-Id: I18cf18f503b837583e8986bfcc1fa33630a4787d
Now that mitaka, the last release with LBaaSv1, has gone EOL cleaning
up any last references to LBaaSv1 in the code.
Change-Id: I68d3b0f5193b52bf46d75d149b4d6e0387695d17
This makes tox use the latest version of the tool from os-testr repo,
which contains some valuable changes, including the one making the gate
fail if for some reason no tests are executed because all of them are
skipped (something that we observe in stable branches right now).
Change-Id: If88be4b310d746ccc885e3d0c1db8a4dfabb2a28
This is a community goal for Ocata. We're already not using any of
the code, but there are some other files and references left over.
These files used to be installed from oslo-incubator:
tools/install_venv.py
tools/install_venv_common.py
tools/with_venv.sh
They were meant to be used by the legacy run_tests.sh, which does not
exist in this repo.
Change-Id: I45c46dcd53ff2f6eaee4faa6da119d5144166533
Partial-Bug: #1639103
Import changes from neutron-vpnaas to run functional tests against
neutron: We need to install the proper version of neutron when
testing neutron changes with functional tests from this repo.
Otherwise those tests install neutron HEAD.
Change-Id: Ic7889f763884aadf7c2e31e273b3857e3d563c7b
Do not install in /tmp/openstack/neutron and leave the git repository
there after the script is run - if zuul-cloner is used.
We run jobs on long lived workers and also on developers machines, let's
cleanup afterwards.
Install into a temporary directory that can be removed with "git clean"
afterwards. Add this directory to ignore list of pep8.
Simplify with using pushd/popd which are bash features, so change
she-bang.
Also, remove setup of ZUUL_BRANCH, this is not needed with current zuul
anymore.
Change-Id: I54d400dea4efdf9ac9b580ff7f0a2bbcceb4df5e
Add gate hooks for the dsvm-functional job including set-up of
configure_for_lbaas_func_testing.sh script and corresponding changes to
tox.ini.
PyMySQL dependency was moved from test_requirements.txt to
functional/requirements.txt.
test_migrations.py was moved from unit tests to functional in
order to prevent it from being skipped in case of db backend
unavailability.
Fixed failing TestModelsMigrations test by importing modules with
missing models in db/models/head.py
Closes-Bug: #1585116
Closes-Bug: #1596984
Change-Id: Ic39805ea0ed330ef7da82043f77077e8a5617ca0
The translations are done via the pep8 checks. This code is no
longer needed and very out of date.
TrivialFix
Change-Id: I39d865dd7b8a3611a7c233b8f18207db984cf079
A while ago we copied Tempest networking API tests in to the Neutron
repo, and along came thousands of lines of code of Tempest testing
infrastructure (neutron.tests.tempest). For a while we periodically
refreshed our fork via: tools/copy_api_tests_from_tempest.sh
It's time to remove tempest fork[1] and use tempest_lib when possible or
tempest itself for code not moved to tempest-lib instead of duplicating,
forking tempest as done in Neutron, Manila & Ironic.
This change is based on the similar work done in Neutron tree[2].
[1] neutron_lbaas.tests.tempest.lib
[2] I4f9193dfe26f2d36985cb480a98709ec182a2f7b
Co-Authored-By: Franklin Naval <franklin.naval@gmail.com>
Closes-Bug: #1536852
Change-Id: I516b37d45200cc120a929ecd9011ff8bb4c45d9f
Since lbaas gate has not switched to -constraints targets yet, we can
remove them right away.
Note: override install_command for releasenotes and cover targets since
corresponding gate jobs do not provide constraints file yet.
Change-Id: If3c143153d0a09378092791e76f1a728fb978aed
tools/tox_install.sh exists to deal with installing neutron without
neutron existing as a pypi package.
The way this operates causes problems in the periodic jobs on the stable
branches. Make it explicit which branch to install in the gate
(zuul-cloner) and via pip (NEUTRON_PIP_LOCATION).
This is done with a BRANCH_NAME variable to make it trivial to change
once master is tagged as stable.
Change-Id: I0667580c3107d3c1e1888a1b2c2a222124d22fe3
This adds a new tox environment, genconfig, which generates sample
neutron LBaaS configuration file using oslo-config-generator.
DocImpact: Update the docs that LBaaS no longer includes static example
configuration files. Instead, use tools/generate_config_file_samples.sh
to generate them and the files generated now end with .sample extension.
Partially-Implements: blueprint autogen-neutron-conf-file
Change-Id: I25507f3bc6e995580aa91a912c2cf4110757df15
Partial-bug: #1199963
These are eventually going to be used in gate instead of unconstrained
jobs. There is some code duplication in commands definitions, but tox
does not allow to inherit definitions with {posargs} substitution.
Made tox_install.sh use constraints file to install both the project and
neutron dependency, if the the first argument is 'constrained'.
Change-Id: I699022b285594edf3c5db10fbdac2f904dc42928
Partial-Bug: #1522503
Depends-On: Ic2f9bc047f886bf2f9a4646e7f39f3b71f0cfc79
In most cases, ZUUL_BRANCH is set in gate, but not all the time. One
exception is e.g. periodic stable jobs, where there is no actual patch
to validate, hence no ZUUL_REF or ZUUL_BRANCH is set. In that case, we
need to help zuul-cloner to determine the proper branch to fetch
neutron.
It could be achieved by e.g. hardcoding the branch using --zuul_branch
CLI argument passed into zuul-cloner. In this patch, I instead set
ZUUL_BRANCH to BRANCH that seems to be always present in all kinds of
jobs. It is then used by zuul-cloner to choose the correct branch.
This fixes the issue for stable/liberty periodic jobs for neutron-lbaas
when we tried to validate it against neutron/master.
Change-Id: I360239a1443f8d4e16210a1ef743912e1bf85f41
Fix the lbaas v2 api job to use the installed neutron and neutron-lbaas
in CI land. I'm not super happy about tox still being in the mix, so
expect it to run testr directly in a future commit, but the output
gets all horked when I switch, and I'd rather get the job fixed and
tackle that second.
Also pulls in a subset of tempest, to be used during the migration
to tempest-lib. Future test commits need to move us away from the
in-tree tempest, and start removing it.
Also yank the check_bash check, which was removed from neutron.
Change-Id: I2790239b8cd361bc4ac7905b4118f34648b97840
When running tox with tox -etempest, tox will install tempest
from a specific commit that the v2 tests are known to work well
with. Then the tests will be run. This also puts a change in
pretty_tox.sh to control the concurrency level because the
tempest tests will fail when running in parallel.
Change-Id: I745293322149390f0e709165f34c144f5c439720
This wrapper was needed until neutron BaseTestCase started using
ExternalLockFixture. Now it can be safely removed.
Change-Id: I2a82504ad19f6daddd24a3c2254e8feefc9399ca
Namespaces are not used anymore, so imports are for oslo_concurrency,
not oslo.concurrency.
lockutils direct call is not supported anymore, so using shipped
lockutils-wrapper instead.
Closes-Bug: #1387092
Change-Id: I2ba2295f8f5d55f272a9d23555940586b25b5a1c
While bash is not available on every environments, there seems to be
a tendency to introduce more bash dependency very casually. This check
is intended to be a reminder to give people a chance to consider
alternatives.
Related-Bug: #1398266
Change-Id: I5103e0d7c111880d9a02dd93de56c567066ed14c
A recent change (commit 0d5a11d9c722870f9c5e31a993219c7e240b4e19)
introduced bash dependency. It broke my environment, where bash
is not available. This change aims to restore it.
As far as I undestand, the change in question requires bash for
the "pipefail" feature. Fortunately there's a more portable
well-known trick for the purpose.
Closes-Bug: #1398266
Change-Id: Id3561d81462923d20ad39584ba4cf8e1a294a8a8
This patch imports some magic to enable showing test output as the
tests run. Seeing output showing tests as they execute is reassuring
that the test run is continuing to make progress. This originated in
tempest and was then brought over to Nova in this commit:
https://review.openstack.org/#/c/121914/
Note the justification in that commit to just copy it instead of move
it to a shared repo.
To get the old behavior where you only get output when something
fails, you can set the TRACE_FAILONLY env var. That originated in
this commit in Nova:
https://review.openstack.org/#/c/123801/
Change-Id: I6a079ad5f630383650c0f9dee09e04250d0e2c5a
In tools/check_i18n.py, the error messages printed out
had format strings that included 5 interpolations, but only
four variables were supplied. This patch simply corrects that
mismatch by including the name of the predicate or checker
that failed.
Closes-Bug: #1263813
Change-Id: I5cacee9ea000f56a9ef45f07367e85f20fa333c7
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on
why this exists.
As of this fix:
https://github.com/eventlet/eventlet/pull/34
which was released in eventlet 0.13, we no longer need the patch.
This has now been removed from oslo-incubator, so this is really just
syncing that removal.
Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
In python 3 print statement is not supported, so we should use
only print() functions.
This patch also removes print in unit test, left by accident
Fixes bug 1226943
Change-Id: I5ace50cb9e149682344b4c986ef9318f8dc50f72
Partial-Bug: #1217100
Using tools/check_i18n.py to scan source directory, and fix most of
the errors.
- Message internationalization
- First letter must be capital
- Using comma instead of percent in LOG.xxx
Note: all extension's description are not touched in this patch,
can be fixed after discussing.
Note: all nicira/check_nvp_config.py print messages are not fixed.
Change-Id: I79ef06fd42f6780beb5019c592662536c2a51864
This change renames everything to Neutron while providing backwards
compatible adjustments for Grizzly configuration files.
implements blueprint: remove-use-of-quantum
Change-Id: Ie7d07ba7c89857e13d4ddc8f0e9b68de020a3d19
A long time ago, quantum/tests/unit became the home for all unit
tests, but these ones in the Cisco plugin directory got left
behind. They have suffered bit-rot and need to be removed.
Also:
- Move the fake Nexus driver to new home.
- Filed new bugs to track the task of improving unit test coverage of
Cisco plugin code.
Fixes: bug #1174311
Change-Id: I372e24aebbe1804e5b6ce62984bfd76b030a44b1