Commit Graph

985 Commits

Author SHA1 Message Date
OpenDev Sysadmins 1a8e62d72c OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
2019-04-19 19:41:14 +00:00
Kyle Mestery d969131246 Merge remote-tracking branch 'origin' into merge-branch
This commit merges the master neutron branch into the feature/lbaasv2
branch. This is needed to get the feature/lbaasv2 branch building again.

Change-Id: Iba59aa20adc6b369b4b9d250afee406159287ba1
2014-10-24 11:05:20 +00:00
Jenkins 37a38cee95 Merge "Remove duplicate import of constants module" 2014-10-23 20:19:28 +00:00
Jenkins 40f0eab356 Merge "Move disabling of metadata and ipv6_ra to _destroy_router_namespace" 2014-10-23 11:55:44 +00:00
Jenkins 3840a1f4fe Merge "Work toward Python 3.4 support and testing" 2014-10-22 19:52:57 +00:00
Jenkins fd8154dd78 Merge "Updated from global requirements" 2014-10-22 00:25:08 +00:00
Carl Baldwin 5e351b0312 Move disabling of metadata and ipv6_ra to _destroy_router_namespace
I noticed that disable_ipv6_ra is called from the wrong place and that
in some cases it was called with a bogus router_id because the code
made an incorrect assumption about the context.  In other case, it was
never called because _destroy_router_namespace was being called
directly.  This patch moves the disabling of metadata and ipv6_ra in
to _destroy_router_namespace to ensure they get called correctly and
avoid duplication.

Change-Id: Ia76a5ff4200df072b60481f2ee49286b78ece6c4
Closes-Bug: #1383495
2014-10-21 20:50:16 +00:00
Jenkins 9fc08d9095 Merge "Check for VPN Objects when deleting interfaces" 2014-10-21 17:37:57 +00:00
Jenkins 87722a7d1d Merge "mock.assert_called_once() is not a valid method" 2014-10-21 17:33:19 +00:00
OpenStack Proposal Bot 5cca365876 Updated from global requirements
Change-Id: Idcbd730f5c781d21ea75e7bfb15959c8f517980f
2014-10-21 12:11:19 +00:00
Angus Lees 8f64098c30 Remove duplicate import of constants module
.. and enable corresponding pylint check now the only offending instance
is fixed.

Change-Id: I35a12ace46c872446b8c87d0aacce45e94d71bae
2014-10-21 16:03:22 +11:00
Jenkins 8cac4e1b60 Merge "Empty files should not contain copyright or license" 2014-10-20 23:13:52 +00:00
Jenkins 60fdf9fd62 Merge "Drop sslutils and versionutils modules" 2014-10-20 17:09:16 +00:00
Jenkins e897894f6f Merge "Updated fileutils and its dependencies" 2014-10-20 15:54:12 +00:00
Jenkins c1f3694863 Merge "VPNaaS Cisco unit test clean-up" 2014-10-20 15:45:38 +00:00
Weidong Shao 00bc0d985a Empty files should not contain copyright or license
Per instruction from
http://docs.openstack.org/developer/hacking/#openstack-licensing

Enable hacking check H104 in this CL.

Change-Id: I435b9d91877499ebe1e33435f06794164a0ecc34
Partial-Bug: #1262424
2014-10-20 00:50:32 +00:00
Jenkins 4936deb338 Merge "Add pylint tox environment and disable all existing warnings" 2014-10-18 08:57:58 +00:00
Ihar Hrachyshka 050a5a6f70 Updated fileutils and its dependencies
This is to avoid fileutils dependency on excutils that are now moved to
oslo.utils.

The following changes are included:

* neutron/openstack/common/__init__.py
  6b048e7 Let oslotest manage the six.move setting for mox

 * neutron/openstack/common/_i18n.py
  9ce1d96 Fix i18n import
  5d40e14 Remove code that moved to oslo.i18n

 * neutron/openstack/common/fileutils.py
  6ff6b4b Switch oslo-incubator to use oslo.utils and remove old modules
  2b966f9 Fix deletion of cached file for policy enforcer
  9c88dc3 file_open: fixed docstring to refer to open() instead of file()
  6c7407b fileutils: port to Python 3
  fcf517d Update oslo log messages with translation domains

 * neutron/openstack/common/log.py
  6c706c5 Delete graduated serialization files
  5d40e14 Remove code that moved to oslo.i18n
  6ff6b4b Switch oslo-incubator to use oslo.utils and remove old modules
  aa74411 log: add missing space in error message
  037dee0 Set stevedore log level to WARN by default
  37c0091 Add unicode coercion of logged messages to ContextFormatter
  6614413 Correct coercion of logged message to unicode
  1188d88 Except socket.error if syslog isn't running
  ac995be Fix E126 pep8 errors
  631f880 Set keystonemiddleware and routes.middleware to log on WARN level
  726d00a Adjust oslo logging to provide adapter is enabled for
  433fa0b Make logging_context_format_string optional in log.set_defaults
  ac92c06 Add default log level for websocket
  5fd77eb Ability to customize default_log_levels for each project
  4d9328c Python 3: enable tests/unit/test_log.py
  cb5a804 Move `mask_password` to strutils

Note: cb5a804 is partially included; that's ok because we don't use the
moved function in Neutron.

Change-Id: I3bfcaff2620b368d807e9468bb7abc01d6471661
2014-10-17 09:50:12 +02:00
Jenkins 32e77da6f3 Merge "Remove sslutils from openstack.common" 2014-10-15 17:49:41 +00:00
Jenkins ff18c6a8b4 Merge "remove E251 exemption from pep8 check" 2014-10-15 10:33:22 +00:00
Jenkins f9814063ec Merge "Avoid constructing a RouterInfo object to get namespace name" 2014-10-15 03:47:07 +00:00
Paul Michali 042c8f354a VPNaaS Cisco unit test clean-up
Removed unused args to mock side-effect function and duplicate
constant.

Change-Id: I5409ce86ccaab86213d65f757f19c1bdf9a66929
Closes-Bug: #1381221
2014-10-14 18:18:15 -04:00
Mark McClain cc52f7409d remove E251 exemption from pep8 check
This change removes the exemption for E251 by addressing unexpected spaces
around keyword/parameter equals

Change-Id: Iff17477e37bef2a97fc58a538d08bcfc35c67751
Partial-Bug: 1329017
2014-10-14 15:39:34 -04:00
Jenkins 1075f28d5c Merge "Update VPN logging to use new i18n functions" 2014-10-14 13:07:03 +00:00
Andrew Boik 47e184c4dd Update VPN logging to use new i18n functions
For log messages in neutron/services/vpn and neutron/db/vpn, replace
_() marker functions with log-level-specific marker functions: _LI(),
_LW(), _LE() from oslo.i18n.

Also, remove _() functions for debug log messages as debug level log
messages should not be translated.

Change-Id: I07fcf25bb6344c47e74d6ee23f9bc08e4b560679
Closes-Bug: #1379811
2014-10-13 10:01:12 -04:00
Jacek Swiderski 8bdbbb35a6 mock.assert_called_once() is not a valid method
mock.assert_called_once() is a no-op that tests nothing. Instead
mock.assert_called_once_with() should be used (or use
assertEqual(1, mock_obj.call_count) if you don't want to check
parameters).

Borrowed HACKING rule from Davanum Srinivas's nova patch to
prevent it from appearing again.

Change-Id: Idac1d3c89c07e13c9a209663f4e557fcb7547821
Closes-Bug: #1365751
Closes-Bug: #1300265
2014-10-13 12:36:49 +02:00
vikas fb96cb1eef Check for VPN Objects when deleting interfaces
When we delete Router interfaces/gateway,
we need to check if any VPN services are
associated with that router.

Closes-Bug:1261598

Change-Id: I7df2b8b130b47ec070d0b0a36b1a62df40532760
2014-10-13 03:03:59 -07:00
Angus Lees c7f20d0c0b Add pylint tox environment and disable all existing warnings
pylintrc update disables all warnings that currently trigger on neutron
code.  The rough plan is to slowly re-enable warning categories as we
clean up code in question.

This change also includes a few ultra-trivial syntax cleanups where it
allowed the check to be immediately enabled for the rest of the
codebase:

- Added missing trailing newlines in several files
  (db/migration/__init__.py, nuage/{nuagedb,syncmanager,common/config}.py)
- Renamed self to cls in @classmethods
  (cisco/db/l3/device_handling_db.py)
- Removed whitespace around '=' in a kwarg
  (cisco/db/l3/device_handling_db.py, cisco/db/n1kv_db_v2.py)
- Updated deprecated pylint 'disable-msg' directive to newer 'disable'
  (cisco/extensions/qos.py)
- File-specific disable for too-many-format-args pending further
  investigation of alternatives
  (ml2/drivers/arista/arista_l3_driver.py)
- Import module rather than object and avoid long line
  (services/l3_router/l3_arista.py)

Change-Id: Ifb0a1a38e33f9073a78658ca578fbd2a42747724
2014-10-12 19:14:29 +11:00
Jenkins 8200868865 Merge "Updated from global requirements" 2014-10-12 06:01:14 +00:00
OpenStack Proposal Bot 694351ac1d Updated from global requirements
Change-Id: Ib0c8c561427f141583d677e86a76cbfe4e2be606
2014-10-11 22:33:01 +00:00
Carl Baldwin de9114d57e Avoid constructing a RouterInfo object to get namespace name
Constructing a RouterInfo object just for a string concatenation is
inefficient and adds more dependence on the class which needs
refactoring.

Change-Id: Ibaf369d6ebe9285a0c845802def59bfa26ac0fd5
2014-10-10 19:02:54 +00:00
Ihar Hrachyshka 9a1792c98d Drop sslutils and versionutils modules
The modules are not used since when we've switched to oslo.messaging.

Change-Id: Ife4298e0bb29ec15404fafe4b48545bd65e038e3
2014-10-10 20:53:46 +02:00
Jenkins de83037a10 Merge "Refactor _process_routers to handle a single router" 2014-10-09 23:35:01 +00:00
Carl Baldwin 29c7d39a65 Refactor _process_routers to handle a single router
The method _process_routers no longer handles multiple routers.  The
only caller of this method would construct a list of exactly one
router in order to make the call.  This made the for loop unnecessary.
The method's logic is too heavy for its current purpose.  This commit
removes much of the weight.

The use of the sets in this method is also no longer necessary.  It
became clear that all of it boiled down to "if the router is not
compatible with with this agent but it is known in router_info from
before then we need to remove it."  This is an exceptional condition
that shouldn't be handled in this method so I raise an exception and
handle it in process_router_update where other router removal is
handled.  Logging was added for this exceptional condition.

The eventlet pool was also obsolete.  It was used to spawn two methods
and there was a waitall at the end.  The other refactoring made it
clear that the two spawns were mutually exclusive.  There was only one
thread spawned for any given invocation of the method and the eventlet
pool is overkill.

Change-Id: Ibeac591b08565d10b2a9730e25a54f2cd11fc2bc
Closes-Bug: #1378398
2014-10-09 18:51:13 +00:00
Jenkins a6af571e01 Merge "Remove all_routers argument from _process_routers" 2014-10-09 18:46:10 +00:00
Jenkins 0d60a29cab Merge "Updated from global requirements" 2014-10-08 22:18:36 +00:00
Carl Baldwin 21d931fc16 Remove all_routers argument from _process_routers
There is no code left that passes True to this argument.  It is dead
code and it should be removed.

Change-Id: I55f71a5c0b96e530e45f2a6463978e8611cbc537
2014-10-08 21:08:41 +00:00
OpenStack Proposal Bot 9fd23f7666 Updated from global requirements
Change-Id: I0e72933320ac6f49b55ef9782c6c19fb7e997bcb
2014-10-07 19:13:11 +00:00
Julien Danjou a3ef6ff0ae Remove sslutils from openstack.common
This module has been imported but is not used. Let's remove it.

Change-Id: I0cafdb7ddc00ce58b0724cee293f5dad6f4a1817
2014-10-07 11:16:49 +02:00
Jenkins d5024b4da3 Merge "Fix setup of Neutron core plugin in VPNaaS UT" 2014-10-07 02:29:25 +00:00
Jenkins 2818de089d Merge "Implement ModelsMigrationsSync test from oslo.db" 2014-10-06 11:41:28 +00:00
Jenkins 41a64362b2 Merge "Removed kombu from requirements" 2014-10-04 22:30:22 +00:00
Jenkins 2895bcdb5b Merge "Open Kilo development" 2014-10-02 17:19:42 +00:00
Kevin Benton ca4d350501 Fix setup of Neutron core plugin in VPNaaS UT
One of the VPNaaS unit test setup routines creates
and extension manager but passes it a class but it
should be passing an instance of that class.

Change-Id: I589cdda0674fdf8fa20d92c2609e1ba6966125d8
2014-10-02 01:16:46 -07:00
Jenkins f8b2f4104b Merge "remove linuxbridge plugin" 2014-10-02 03:26:22 +00:00
Mark McClain 6d4f2527d5 remove linuxbridge plugin
This changeset removes the linuxbridge plugin, but retains the agent for ML2.
The database models were not removed since operators will need to migrate the
data.

Additionally, the ml2 migration script was altered to support Juno.  For
testing, a user must either run the migration against the icehouse
scheme or run the update, manually change alembic_version to juno and
then run the migration script.  Once the juno migration is added, this
manually step will not be required.

Change-Id: I70689b4247947e6dc08e80fd9b31da9dc691d259
Partial-Bug: 1323729
2014-10-01 18:08:25 +00:00
Thierry Carrez 07bb0ef6cc Open Kilo development
Bump pre-version to 2015.1 to formally open master branch to Kilo
development.

Change-Id: Ia48ad29dc1b31b1fbcb14dfffad571659ec66700
2014-09-30 16:47:21 +02:00
Ann Kamyshnikova 6aed48fba1 Implement ModelsMigrationsSync test from oslo.db
Add tests to verify that database migrations produce
the same schema as the database models.

Also for MySQL, check that all tables are configured to use InnoDB
as the storage engine.
These tests make use of the ModelsMigrationsSync test class from
oslo.db and the load_tests protocol from Python unittest.

Closes-bug: #1346444

Change-Id: Ic0e7eb37c30cc5e94cbdbddf07a6dc1ebf377c17
2014-09-30 11:55:06 +04:00
Jenkins 2bc0eaadee Merge "Do not assume order of report list elements" 2014-09-29 16:58:13 +00:00
johndavidge ad745971fe Do not assume order of report list elements
This fixes the test_report_multiple_services unit test that breaks with a
randomized PYTHONHASHSEED (see the bug report).

The test assumed that the report list from self.driver.report_status() had
elements in a particular order. Found with PYTHONHASHSEED=2455351445.

The fix refactors the test case to handle an unsorted report list by
sorting it before checking equality.

Partial-bug: #1348818

Note: There are several other unrelated unit tests that also break with a
randomized PYTHONHASHSEED, but they are not addressed here. They will be
addressed in separate patches.

Change-Id: I542c3818821fa2f6e460fd254a3842530ecea8d9
2014-09-29 11:00:51 +00:00