The README file was not updated during the services split to accurately
reflect what project this was. Also, update CONTRIBUTING.rst, HACKING.rst,
and TESTING.rst to point to their Neutron counterparts. This makes
maintaining a single copy easier.
Change-Id: I4d9cee887753fc6d7b8b1116deebd2a90faa0f3b
Fix some uses of assertCalledOnceWith, which seems like a mistake of
assert_called_once_with.
Also, add a hacking check to prevent the mistake.
Closes-Bug: #1397184
Change-Id: I12d077e2724d52eff65d55aff1130fbbb69671b1
Don't translate debug level logs and enforce log hints
Our translation policy
(https://wiki.openstack.org/wiki/LoggingStandards#Log_Translation) calls
for not translating debug level logs. This is to help prioritize log
translation. Furthermore translation has a performance overhead, even if
the log isn't used (since neutron doesn't support lazy translation yet).
NOTE: this is done on a directory by directory basis to ensure that we
do not have too many conflicts and rebases.
Add a local hacking rule to enforce this.
This patch set enforces the directory neutron/agents
Partial-bug: #1320867
Change-Id: I4bd562e5138c2d2850072440aa121f27e902463a
mock.assert_called_once() is a no-op that tests nothing. Instead
mock.assert_called_once_with() should be used (or use
assertEqual(1, mock_obj.call_count) if you don't want to check
parameters).
Borrowed HACKING rule from Davanum Srinivas's nova patch to
prevent it from appearing again.
Change-Id: Idac1d3c89c07e13c9a209663f4e557fcb7547821
Closes-Bug: #1365751
Closes-Bug: #1300265
We have git to track authorship, so let's not pad source files
with it as well.
A hacking check has been added for this. The value is N322.
Change-Id: Iab0b64d417e0bb41a6b455e2ac377deee64ec3ee
jsonutils provides multiple benefits in comparison to pure stdlib json
(like using simplejson on Python 2.6).
Similar patch was already merged before [1], but since it lacked hacking
rule to enforce jsonutils usage, new occurrences of stdlib json module
usage were introduced.
This patch switches all the code to using jsonutils and adds a hacking
rule to enforce the rule.
The hacking rule requires that jsonutils module does not mimic as 'json'
thru using import renames, so the code was updated not to rename the
module when doing import.
The hacking rule was shamelessly copied from the corresponding nova
review [2].
[1]: https://review.openstack.org/#/c/99760/
[2]: https://review.openstack.org/111296/
Change-Id: Ie7a5bb76445e15cde9fbf9ff3d2101a014637b37
Update a number of files to add missing translation support.
The patch adds a new hacking check - N320. This ensures that
all log messages, except debug ones, have translations.
A '# noqa' indicates that the validation will not be done on
the specific log message. This should be used in cases where
the translations do not need to be done, for example, the log
message is logging raw data.
Change-Id: I3e1fdd04d87b09dff50950b5e85f5cacfb29afdc
Closes-bug: #1314994
* Point to new location for hacking doc
(http://docs.openstack.org/developer/hacking/)
* Remove openstack-common section because already in main hacking doc
Change-Id: I7fbcfe13469a75fed08700ccbe07fefbee33db22
Reference the OpenStack hacking guide in HACKING.rst and remove
duplicate entries. Adds placeholder section for neutron specific
rules.
Change-Id: I4bfbab50b77e7592178dda44c7f4f52edc7fdc21
Example of Human Alphabetical Order Examples section in HACKING.rst
is wrong, this patch fixes it to the right order.
Closes-Bug: #1213568
Change-Id: Ib7f8baf20c437c3fa776201998c36f33bdde2f78
This change renames everything to Neutron while providing backwards
compatible adjustments for Grizzly configuration files.
implements blueprint: remove-use-of-quantum
Change-Id: Ie7d07ba7c89857e13d4ddc8f0e9b68de020a3d19
There are several common fixtures that every test case wants. Following
the pattern in Nova, add a common base test case class to hold these things.
Change-Id: I2d2cd91e5051d9cbf230e6f48985d6eddcb7b58a
As part of the move towards testr and parallel test running, we
start to use testtools and fixtures to make the test suite
resilient and more pedantic.
Part of blueprint grizzly-testtools
Change-Id: I90250de9fe21237db34f6a50b89b15863e270aa5
Replaced logging with openstack.common.log
Removed imports where logging is not used
Fixes bug #1095541
Change-Id: I5b03d9697dde3ef3520f67d1d8166f7af7689551
caoyuan