openstack
/
neutron
Code Issues Proposed changes

Improve logging upon failure in iptables functional tests 

This will help us nail down a more accurate and efficient logstash
query.

Change-Id: Iee4238e358f7b056e373c7be8d6aa3202117a680
Related-Bug: #1478847
This commit is contained in:
Assaf Muller 2015-08-28 16:41:07 -04:00
parent 4f80223277
commit 013fdcd2a6
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
neutron/tests/functional/agent/linux/test_iptables.py
View File

@ -83,14 +83,23 @@ class IptablesManagerTestCase(functional_base.BaseSudoTestCase):
self.client.namespace, self.server.namespace,
self.server.ip, self.port, protocol)
self.addCleanup(netcat.stop_processes)
self.assertTrue(netcat.test_connectivity())
filter_params = 'direction %s, port %s and protocol %s' % (
direction, port, protocol)
self.assertTrue(netcat.test_connectivity(),
'Failed connectivity check before applying a filter '
'with %s' % filter_params)
self.filter_add_rule(
fw_manager, self.server.ip, direction, protocol, port)
with testtools.ExpectedException(RuntimeError):
with testtools.ExpectedException(
RuntimeError,
msg='Wrongfully passed a connectivity check after applying '
'a filter with %s' % filter_params):
netcat.test_connectivity()
self.filter_remove_rule(
fw_manager, self.server.ip, direction, protocol, port)
self.assertTrue(netcat.test_connectivity(True))
self.assertTrue(netcat.test_connectivity(True),
'Failed connectivity check after removing a filter '
'with %s' % filter_params)
def test_icmp(self):
self.client.assert_ping(self.server.ip)