DHCP: enhance DHCPAgent startup procedure
During DhcpAgent startup procedure all the following networks initialization is actually perform twice: * Killing old dnsmasq processes * set and configure all TAP interfaces * building all Dnsmasq config files (lease and host files) * launching dnsmasq processes What is done during the second iteration is just clean and redo exactly the same another time! This is really inefficient and increase dramatically DHCP startup time (near twice than needed). Initialization process 'sync_state' method is called twice: * one time during init_host() * another time during _report_state() sync_state() call must stay in init_host() due to bug #1420042. sync_state() is always called during startup in init_host() and will be periodically called by periodic_resync() to do reconciliation. Hence it can safely be removed from the run() method. Change-Id: Id6433598d5c833d2e86be605089d42feee57c257 Closes-bug: #1651368 Closes-Bug: #1650611 (cherry picked from commitf15851b989
) (cherry picked from commitae0a31d8b0
)
This commit is contained in:
parent
80fb54d8dc
commit
21963618ca
|
@ -94,7 +94,6 @@ class DhcpAgent(manager.Manager):
|
|||
|
||||
def run(self):
|
||||
"""Activate the DHCP agent."""
|
||||
self.sync_state()
|
||||
self.periodic_resync()
|
||||
|
||||
def call_driver(self, action, network, **action_kwargs):
|
||||
|
|
|
@ -246,42 +246,35 @@ class TestDhcpAgent(base.BaseTestCase):
|
|||
# sync_state is needed for this test
|
||||
cfg.CONF.set_override('report_interval', 1, 'AGENT')
|
||||
with mock.patch.object(dhcp_agent.DhcpAgentWithStateReport,
|
||||
'sync_state',
|
||||
autospec=True) as mock_sync_state:
|
||||
with mock.patch.object(dhcp_agent.DhcpAgentWithStateReport,
|
||||
'periodic_resync',
|
||||
autospec=True) as mock_periodic_resync:
|
||||
with mock.patch(state_rpc_str) as state_rpc:
|
||||
with mock.patch.object(sys, 'argv') as sys_argv:
|
||||
sys_argv.return_value = [
|
||||
'dhcp', '--config-file',
|
||||
base.etcdir('neutron.conf')]
|
||||
cfg.CONF.register_opts(dhcp_config.DHCP_AGENT_OPTS)
|
||||
config.register_interface_driver_opts_helper(cfg.CONF)
|
||||
config.register_agent_state_opts_helper(cfg.CONF)
|
||||
cfg.CONF.register_opts(interface.OPTS)
|
||||
common_config.init(sys.argv[1:])
|
||||
agent_mgr = dhcp_agent.DhcpAgentWithStateReport(
|
||||
'testhost')
|
||||
eventlet.greenthread.sleep(1)
|
||||
agent_mgr.after_start()
|
||||
mock_sync_state.assert_called_once_with(agent_mgr)
|
||||
mock_periodic_resync.assert_called_once_with(agent_mgr)
|
||||
state_rpc.assert_has_calls(
|
||||
[mock.call(mock.ANY),
|
||||
mock.call().report_state(mock.ANY, mock.ANY,
|
||||
mock.ANY)])
|
||||
'periodic_resync',
|
||||
autospec=True) as mock_periodic_resync:
|
||||
with mock.patch(state_rpc_str) as state_rpc:
|
||||
with mock.patch.object(sys, 'argv') as sys_argv:
|
||||
sys_argv.return_value = [
|
||||
'dhcp', '--config-file',
|
||||
base.etcdir('neutron.conf')]
|
||||
cfg.CONF.register_opts(dhcp_config.DHCP_AGENT_OPTS)
|
||||
config.register_interface_driver_opts_helper(cfg.CONF)
|
||||
config.register_agent_state_opts_helper(cfg.CONF)
|
||||
cfg.CONF.register_opts(interface.OPTS)
|
||||
common_config.init(sys.argv[1:])
|
||||
agent_mgr = dhcp_agent.DhcpAgentWithStateReport(
|
||||
'testhost')
|
||||
eventlet.greenthread.sleep(1)
|
||||
agent_mgr.after_start()
|
||||
mock_periodic_resync.assert_called_once_with(agent_mgr)
|
||||
state_rpc.assert_has_calls(
|
||||
[mock.call(mock.ANY),
|
||||
mock.call().report_state(mock.ANY, mock.ANY,
|
||||
mock.ANY)])
|
||||
|
||||
def test_run_completes_single_pass(self):
|
||||
with mock.patch(DEVICE_MANAGER):
|
||||
dhcp = dhcp_agent.DhcpAgent(HOSTNAME)
|
||||
attrs_to_mock = dict(
|
||||
[(a, mock.DEFAULT) for a in
|
||||
['sync_state', 'periodic_resync']])
|
||||
with mock.patch.multiple(dhcp, **attrs_to_mock) as mocks:
|
||||
with mock.patch.object(dhcp,
|
||||
'periodic_resync') as periodic_resync_mock:
|
||||
dhcp.run()
|
||||
mocks['sync_state'].assert_called_once_with()
|
||||
mocks['periodic_resync'].assert_called_once_with()
|
||||
periodic_resync_mock.assert_called_once_with()
|
||||
|
||||
def test_call_driver(self):
|
||||
network = mock.Mock()
|
||||
|
|
Loading…
Reference in New Issue