openstack
/
neutron
Code Issues Proposed changes

Don't share a network with all tenants 

Other tenants may appreciate random networks not popping up for
miliseconds in their net-list; and other test cases executed in parallel
may also benefit, especially when they e.g. attempt to validate net-list
result; or boot an instance w/o specifying a port or network to use.

There is still more work on tempest tests side.

Original patch was for neutron-tempest-plugin:
https://review.openstack.org/#/c/550987/
and this is only backport to stable/Pike branch which still
uses tempest tests from neutron repo.

Depends-On: https://review.openstack.org/#/c/571676/
Change-Id: I88eaa1bb65482557912c2d304800d782e730a6b6
Closes-Bug: #1753209
This commit is contained in:
Slawek Kaplonski 2018-06-01 11:54:28 +02:00
parent 8c7dde0743
commit 221df78612
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
neutron/tests/tempest/api/admin/test_shared_network_extension.py
View File

@ -263,25 +263,9 @@ class RBACSharedNetworksTest(base.BaseAdminNetworkTest):
with testtools.ExpectedException(lib_exc.Conflict):
self.admin_client.delete_rbac_policy(res['policy']['id'])
# a wildcard policy should allow the specific policy to be deleted
# since it allows the remaining port
wild = self.admin_client.create_rbac_policy(
object_type='network', object_id=res['network']['id'],
action='access_as_shared', target_tenant='*')['rbac_policy']
self.admin_client.delete_rbac_policy(res['policy']['id'])
# now that wildcard is the only remaining, it should be subjected to
# to the same restriction
with testtools.ExpectedException(lib_exc.Conflict):
self.admin_client.delete_rbac_policy(wild['id'])
# similarly, we can't update the policy to a different tenant
with testtools.ExpectedException(lib_exc.Conflict):
self.admin_client.update_rbac_policy(
wild['id'], target_tenant=self.client2.tenant_id)
self.client.delete_port(port['id'])
# anchor is gone, delete should pass
self.admin_client.delete_rbac_policy(wild['id'])
self.admin_client.delete_rbac_policy(res['policy']['id'])
@decorators.idempotent_id('34d627da-a732-68c0-2e1a-bc4a19246698')
def test_delete_self_share_rule(self):