openstack
/
neutron
Code Issues Proposed changes

Enforce log hints in neutron.services 

This change enforces log hints use and removes debug level log
translation, modifications are validated through a hacking rule.

Validate that hacking rules apply to directories:
    - neutron/services

Change-Id: Ib744b7a94705afbefeb50b5dce933d226831f580
Partial-bug: #1320867
This commit is contained in:
Cedric Brandily 2014-11-11 17:18:19 +01:00 committed by Romil Gupta
parent 8a99a4a35f
commit 6e7614fabd
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
neutron/hacking/checks.py
View File

@ -57,10 +57,7 @@ def _directory_to_check_translation(filename):
"neutron/openstack",
"neutron/scheduler",
"neutron/server",
"neutron/services/firewall",
"neutron/services/l3_router",
"neutron/services/loadbalancer",
"neutron/services/metering"]
"neutron/services"]
return any([dir in filename for dir in dirs])

11
neutron/services/service_base.py
View File

@ -20,6 +20,7 @@ import six
from neutron.api import extensions
from neutron.db import servicetype_db as sdb
from neutron.openstack.common import excutils
from neutron.openstack.common.gettextutils import _LE, _LI
from neutron.openstack.common import importutils
from neutron.openstack.common import log as logging
from neutron.services import provider_configuration as pconf
@ -78,14 +79,14 @@ def load_drivers(service_type, plugin):
drivers[provider['name']] = importutils.import_object(
provider['driver'], plugin
)
LOG.debug(_("Loaded '%(provider)s' provider for service "
"%(service_type)s"),
LOG.debug("Loaded '%(provider)s' provider for service "
"%(service_type)s",
{'provider': provider['driver'],
'service_type': service_type})
except ImportError:
with excutils.save_and_reraise_exception():
LOG.exception(_("Error loading provider '%(provider)s' for "
"service %(service_type)s"),
LOG.exception(_LE("Error loading provider '%(provider)s' for "
"service %(service_type)s"),
{'provider': provider['driver'],
'service_type': service_type})
@ -95,7 +96,7 @@ def load_drivers(service_type, plugin):
None, service_type)
default_provider = provider['name']
except pconf.DefaultServiceProviderNotFound:
LOG.info(_("Default provider is not specified for service type %s"),
LOG.info(_LI("Default provider is not specified for service type %s"),
service_type)
return drivers, default_provider