openstack
/
neutron
Code Issues Proposed changes

Remove test_external_network_visibility 

This test was left behind according to plan laid out in patch [1].
Make its removal conditional to the Tempest sync-up patch.

[1] https://review.openstack.org/#/c/280427/

Related-bug: 1553595
Related-bug: 1552960

Conflicts:
	neutron/tests/api/test_networks.py

Change-Id: Ia85e7d03c32b5e2db901aed2c13bafe83896be0b
(cherry picked from commit cc863e0715)
This commit is contained in:
Armando Migliaccio 2016-03-11 08:00:34 -08:00 committed by Ihar Hrachyshka
parent 4b1d8dca9b
commit e17f391ab7
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
neutron/tests/api/test_networks.py
View File

@ -12,7 +12,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import itertools
import netaddr
import six
@ -393,29 +392,6 @@ class NetworksTestJSON(base.BaseNetworkTest):
enable_dhcp=True,
**self.subnet_dict(['gateway', 'host_routes', 'dns_nameservers']))
@test.attr(type='smoke')
@test.idempotent_id('af774677-42a9-4e4b-bb58-16fe6a5bc1ec')
def test_external_network_visibility(self):
"""Verifies user can see external networks but not subnets."""
body = self.client.list_networks(**{'router:external': True})
networks = [network['id'] for network in body['networks']]
self.assertNotEmpty(networks, "No external networks found")
nonexternal = [net for net in body['networks'] if
not net['router:external']]
self.assertEmpty(nonexternal, "Found non-external networks"
" in filtered list (%s)." % nonexternal)
self.assertIn(CONF.network.public_network_id, networks)
subnets_iter = (network['subnets'] for network in body['networks'])
# subnets_iter is a list (iterator) of lists. This flattens it to a
# list of UUIDs
public_subnets_iter = itertools.chain(*subnets_iter)
body = self.client.list_subnets()
subnets = [sub['id'] for sub in body['subnets']
if sub['id'] in public_subnets_iter]
self.assertEmpty(subnets, "Public subnets visible")
class BulkNetworkOpsTestJSON(base.BaseNetworkTest):