openstack
/
neutron
Code Issues Proposed changes

Raise NotImplementedError instead of NotImplemented 

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).

NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).

It makes no sense to raise a constant. The exception should
be raised instead.

Change-Id: I4969e26eb7b46f008ea3c8bd0093490c425f7069
Closes-Bug: #1339855
This commit is contained in:
Christian Berendt 2014-07-04 13:12:26 +02:00
parent e2c72495f4
commit e8e2392321
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/agent/linux/polling.py
View File

@ -52,7 +52,7 @@ class BasePollingManager(object):
self._polling_completed = True
def _is_polling_required(self):
raise NotImplemented
raise NotImplementedError()
@property
def is_polling_required(self):

3
neutron/tests/unit/agent/linux/test_polling.py
View File

@ -43,6 +43,9 @@ class TestBasePollingManager(base.BaseTestCase):
super(TestBasePollingManager, self).setUp()
self.pm = polling.BasePollingManager()
def test__is_polling_required_should_not_be_implemented(self):
self.assertRaises(NotImplementedError, self.pm._is_polling_required)
def test_force_polling_sets_interval_attribute(self):
self.assertFalse(self.pm._force_polling)
self.pm.force_polling()