openstack
/
nova
Code Issues Proposed changes

Merge "Make supports_direct_io work on 4096b sector size" into stable/pike

This commit is contained in:
Zuul 2018-12-13 12:59:46 +00:00 committed by Gerrit Code Review
parent 1abdb4ca22 ba844f2a7c
commit f25cc4ac92
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nova/virt/libvirt/driver.py
View File

@ -3076,8 +3076,8 @@ class LibvirtDriver(driver.ComputeDriver):
fd = None
try:
fd = os.open(testfile, os.O_CREAT | os.O_WRONLY | os.O_DIRECT)
# Check is the write allowed with 512 byte alignment
align_size = 512
# Check is the write allowed with 4096 byte alignment
align_size = 4096
m = mmap.mmap(-1, align_size)
m.write(b"x" * align_size)
os.write(fd, m)

8
releasenotes/notes/bug-1801702-c8203d3d55007deb.yaml Normal file
View File

@ -0,0 +1,8 @@
---
fixes:
- |
When testing whether direct IO is possible on the backing storage
for an instance, Nova now uses a block size of 4096 bytes instead
of 512 bytes, avoiding issues when the underlying block device has
sectors larger than 512 bytes. See bug
https://launchpad.net/bugs/1801702 for details.