openstack
/
nova
Code Issues Proposed changes

Skip migrations test_walk_versions instead of pass 

When there is no db engine configured for the migration tests,
the test_walk_versions test was passing, rather than skipping,
because it contained a for-loop and no check for the length of the
sequence being iterated over.
This patch checks the length of the configured engines and
properly skips the test when there are no engines.

Change-Id: I4078655f01638c22cf029f088018b8be93d6a01a
Co-Authored-By: Devananda van der Veen<devananda.vdv@gmail.com>
Closes-bug: #1327397
This commit is contained in:
Joe Gordon 2014-06-13 14:46:37 -07:00
parent 092a214820
commit 08201764d1
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/tests/db/test_migrations.py
View File

@ -119,6 +119,9 @@ class CommonTestsMixIn(object):
BaseMigrationTestCase.
"""
def test_walk_versions(self):
if not self.engines:
self.skipTest("No engines initialized")
for key, engine in self.engines.items():
# We start each walk with a completely blank slate.
self._reset_database(key)