openstack
/
nova
Code Issues Proposed changes

Fix check_can_live_migrate_destination() in ComputeV4Proxy 

There was a mismatch in the V4 proxy in the call signatures of this
function. This was missed because the "destination" parameter is passed
in the rpcapi as the host to contact, which is consumed by the rpc
layer and not passed. Since it was not called one of the standard
names (either host if to be not passed, or host_param if to be passed),
this was missed.

Change-Id: Idf2160934dade650ed02b672f3b64cb26247f8e6
Closes-Bug: #1442602
This commit is contained in:
Dan Smith 2015-04-10 07:10:52 -07:00
parent f9347ebd3a
commit 0c08f7f2ef
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nova/compute/manager.py
View File

@ -6582,10 +6582,10 @@ class _ComputeV4Proxy(object):
def change_instance_metadata(self, ctxt, instance, diff):
return self.manager.change_instance_metadata(ctxt, instance, diff)
def check_can_live_migrate_destination(self, ctxt, instance, destination,
def check_can_live_migrate_destination(self, ctxt, instance,
block_migration, disk_over_commit):
return self.manager.check_can_live_migrate_destination(
ctxt, instance, destination, block_migration, disk_over_commit)
ctxt, instance, block_migration, disk_over_commit)
def check_can_live_migrate_source(self, ctxt, instance, dest_check_data):
return self.manager.check_can_live_migrate_source(ctxt, instance,