openstack
/
nova
Code Issues Proposed changes

Fix typo and add test for refresh_instance_security_rules 

Change Ia36b0dfb adds virt driver API method
refresh_instance_security_rules but there is a typo in the method's
docstring and it needs to be covered in test_virt_drivers.py.

Closes-Bug: #1290036

Change-Id: Idacffe2087f0bec6290e3422d1e777376b489615
This commit is contained in:
Matt Riedemann 2014-03-09 08:52:05 -07:00
parent 5a98d7b61f
commit 100c42ed15
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
nova/tests/virt/test_virt_drivers.py
View File

@ -546,6 +546,12 @@ class _VirtDriverTestCase(_FakeDriverBackendTestCase):
instance_ref, network_info = self._get_running_instance()
self.connection.refresh_security_group_members(1)
@catch_notimplementederror
def test_refresh_instance_security_rules(self):
# FIXME: Create security group and add the instance to it
instance_ref, network_info = self._get_running_instance()
self.connection.refresh_instance_security_rules(instance_ref)
@catch_notimplementederror
def test_refresh_provider_fw_rules(self):
instance_ref, network_info = self._get_running_instance()

2
nova/virt/driver.py
View File

@ -819,7 +819,7 @@ class ComputeDriver(object):
Gets called when an instance gets added to or removed from
the security group the instance is a member of or if the
group gains or looses a rule.
group gains or loses a rule.
"""
raise NotImplementedError()