openstack
/
nova
Code Issues Proposed changes

Add comment about how status field changed 

There are some review comments on the status , vm_state
changes confusion in patch https://review.openstack.org/#/c/258472
for this bug, so this patch added some comments to make
reviewer easier to read the code logic.

Change-Id: I65e77feeddcf477bd5550baaa440b4a1a325bb91
Related-Bug: 1526715
This commit is contained in:
jichenjc 2016-07-25 18:17:08 +08:00
parent a14d5ff5ba
commit 4b73cd9bb1
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/api/openstack/compute/servers.py
View File

@ -217,6 +217,9 @@ class ServersController(wsgi.Controller):
# Verify search by 'status' contains a valid status.
# Convert it to filter by vm_state or task_state for compute_api.
# For non-admin user, vm_state and task_state are filtered through
# remove_invalid_options function, based on value of status field.
# Set value to vm_state and task_state to make search simple.
search_opts.pop('status', None)
if 'status' in req.GET.keys():
statuses = req.GET.getall('status')