openstack/nova
Code Issues Proposed changes

libvirt: remove redundant and broken iscsi volume test

Browse Source 
This same test has existed in os-brick for a long time:

I092a56e52bcea6adb6cb018cd059e6126a1dc07d

And since _get_target_portals_from_iscsiadm_output has been
changed in os-brick master to return a tuple instead of a
list, this test is actually blocking us from being able to
use os-brick 1.12.0.

This change just removes it since it's no longer needed in nova.

Change-Id: I82c31cc3b2ea3869ec37ff6add53abaec7a8591e
Closes-Bug: #1672670
This commit is contained in:
Matt Riedemann 2017-04-24 14:13:16 -04:00
parent c3597c87d8
commit 620e630a69
1 changed files with 0 additions and 25 deletions

25
nova/tests/unit/virt/libvirt/volume/test_iscsi.py

@ -21,31 +21,6 @@ from nova.virt.libvirt.volume import iscsi
class LibvirtISCSIVolumeDriverTestCase(
test_volume.LibvirtISCSIVolumeBaseTestCase):
# TODO(mriedem): move this to os-brick
def test_iscsiadm_discover_parsing(self):
# Ensure that parsing iscsiadm discover ignores cruft.
targets = [
["192.168.204.82:3260,1",
("iqn.2010-10.org.openstack:volume-"
"f9b12623-6ce3-4dac-a71f-09ad4249bdd3")],
["192.168.204.82:3261,1",
("iqn.2010-10.org.openstack:volume-"
"f9b12623-6ce3-4dac-a71f-09ad4249bdd4")]]
# This slight wonkiness brought to you by pep8, as the actual
# example output runs about 97 chars wide.
sample_input = """Loading iscsi modules: done
Starting iSCSI initiator service: done
Setting up iSCSI targets: unused
%s %s
%s %s
""" % (targets[0][0], targets[0][1], targets[1][0], targets[1][1])
driver = iscsi.LibvirtISCSIVolumeDriver("none")
out = driver.connector._get_target_portals_from_iscsiadm_output(
sample_input)
self.assertEqual(targets, out)
def test_libvirt_iscsi_driver(self, transport=None):
libvirt_driver = iscsi.LibvirtISCSIVolumeDriver(self.fake_host)
self.assertIsInstance(libvirt_driver.connector,