openstack
/
nova
Code Issues Proposed changes

document why we disable usb_tablet in code 

This provides a code level explanation for why we disregard the user
option for use_usb_tablet when the spice agent is enabled. It came up
in a bug report, and having the comment close to the code helps carry
the information forward.

Change-Id: I7945e921b6283519d91e234584d99d9e82218e6d
Closes-Bug: #1356633
This commit is contained in:
Sean Dague 2014-09-09 18:06:38 -04:00
parent 42e4c04e9e
commit 78294b9ecf
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
nova/virt/libvirt/driver.py
View File

@ -3785,8 +3785,11 @@ class LibvirtDriver(driver.ComputeDriver):
consolepty.type = "pty"
guest.add_device(consolepty)
# We want a tablet if VNC is enabled,
# or SPICE is enabled and the SPICE agent is disabled
# We want a tablet if VNC is enabled, or SPICE is enabled and
# the SPICE agent is disabled. If the SPICE agent is enabled
# it provides a paravirt mouse which drastically reduces
# overhead (by eliminating USB polling).
#
# NB: this implies that if both SPICE + VNC are enabled
# at the same time, we'll get the tablet whether the
# SPICE agent is used or not.