Remove redundancies from AggregateRequestFiltersTest.setUp

Change I9ab9d7d65378be564b3731b5227ede8cece71bef made
AggregateRequestFiltersTest extend ProviderUsageBaseTestCase
but left a lot of redundant setUp for fixtures and services
in it which might be contributing to test_fail_set_az failing
intermittently. My theory is that we're starting multiple API
and scheduler workers and when setting an AZ on an aggregate
the API will RPC cast to all schedulers to store that metadata
information in the scheduler process. Since we have more than
one scheduler process, and I'm not sure how stable the RPC cast
fanout capability is in the fake messaging driver, we could be
hitting a scheduler worker during the test that does not have
the AZ metadata and the AvailabilityZoneFilter filters out the
expected host.

This simply removes the redundant setUp. Even if this isn't the
root of the problem it at least rules it out.

Change-Id: I45107ff686456d5db91c615830fa443b3902ddfb
Partial-Bug: #1844174
This commit is contained in:
Matt Riedemann 2019-09-16 16:33:58 -04:00
parent f9cb498c65
commit c074a7bd31
1 changed files with 0 additions and 21 deletions

View File

@ -66,29 +66,8 @@ class AggregateRequestFiltersTest(
compute_driver = 'fake.MediumFakeDriver'
def setUp(self):
self.flags(compute_driver=self.compute_driver)
super(AggregateRequestFiltersTest, self).setUp()
self.useFixture(policy_fixture.RealPolicyFixture())
self.useFixture(nova_fixtures.NeutronFixture(self))
self.useFixture(nova_fixtures.AllServicesCurrent())
placement = self.useFixture(func_fixtures.PlacementFixture())
self.placement_api = placement.api
api_fixture = self.useFixture(nova_fixtures.OSAPIFixture(
api_version='v2.1'))
self.admin_api = api_fixture.admin_api
self.admin_api.microversion = self.microversion
self.api = self.admin_api
# the image fake backend needed for image discovery
nova.tests.unit.image.fake.stub_out_image_service(self)
self.start_service('conductor')
self.scheduler_service = self.start_service('scheduler')
self.computes = {}
self.aggregates = {}
self._start_compute('host1')