openstack
/
nova
Code Issues Proposed changes

Log the actual instance.info_cache when empty in floating ip associate 

This attempts to add some enlightenment to the case where we try to
associate a floating ip for an instance and hit the case where there
is no info_cache. We need to know if it's actually None, or empty.

Related-Bug: #1249065

Change-Id: Ic0051d1d520f800d845b7006b5b95be5d8edf7c9
This commit is contained in:
Dan Smith 2015-05-07 08:42:49 -07:00 committed by Matt Riedemann
parent 1c292f3337
commit c13f42e36c
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/api/openstack/compute/contrib/floating_ips.py
View File

@ -181,6 +181,9 @@ class FloatingIPActionController(wsgi.Controller):
instance = common.get_instance(self.compute_api, context, id)
cached_nwinfo = compute_utils.get_nw_info_for_instance(instance)
if not cached_nwinfo:
LOG.warning(
_LW('Info cache is %r during associate') % instance.info_cache,
instance=instance)
msg = _('No nw_info cache associated with instance')
raise webob.exc.HTTPBadRequest(explanation=msg)

3
nova/api/openstack/compute/plugins/v3/floating_ips.py
View File

@ -194,6 +194,9 @@ class FloatingIPActionController(wsgi.Controller):
instance = common.get_instance(self.compute_api, context, id)
cached_nwinfo = compute_utils.get_nw_info_for_instance(instance)
if not cached_nwinfo:
LOG.warning(
_LW('Info cache is %r during associate') % instance.info_cache,
instance=instance)
msg = _('No nw_info cache associated with instance')
raise webob.exc.HTTPBadRequest(explanation=msg)