openstack/nova
Code Issues Proposed changes

Change log level to debug for migrations pairing

Browse Source 
For resize/cold-migration it's possible that instance
already changed host to destination, but no confirm/revert
has happened yet. In that case resource tracked starts spamming
errors, because it's impossible to match migration and instance.
It's safe to lower log level to debug in that case.

Change-Id: I70cb7426e0e2849ee7d01205ce7b2d883a126d66
Closes-Bug: #1555320
This commit is contained in:
Timofey Durakov 2016-10-04 16:42:09 +03:00
parent 434c0a31ac
commit f085fbd7d3
1 changed files with 7 additions and 4 deletions

11
nova/compute/resource_tracker.py

@ -30,7 +30,7 @@ from nova.compute import task_states
from nova.compute import vm_states
import nova.conf
from nova import exception
from nova.i18n import _, _LE, _LI, _LW
from nova.i18n import _, _LI, _LW
from nova import objects
from nova.objects import base as obj_base
from nova.objects import migration as migration_obj
@ -534,9 +534,12 @@ class ResourceTracker(object):
# NOTE(danms): If this happens, we don't set it here, and
# let the code either fail or lazy-load the instance later
# which is what happened before we added this optimization.
# This _should_ not be possible, of course.
LOG.error(_LE('Migration for instance %(uuid)s refers to '
'another host\'s instance!'),
# NOTE(tdurakov) this situation is possible for resize/cold
# migration when migration is finished but haven't yet
# confirmed/reverted in that case instance already changed host
# to destination and no matching happens
LOG.debug('Migration for instance %(uuid)s refers to '
'another host\'s instance!',
{'uuid': migration.instance_uuid})
@utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE)