openstack
/
openstack-ansible-haproxy_server
Code Issues Proposed changes

Remove 'ignore_errors: true' in favor of 'failed_when: false' 

This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.

It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.

Change-Id: I460b4eb12c30d66769f3093a451dc39c77150ea3
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter 2016-10-14 16:44:03 -05:00
parent ac801399f5
commit 696056db67
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tasks/haproxy_add_ppa_repo.yml
View File

@ -53,7 +53,7 @@
state: "present"
register: add_keys
until: add_keys|success
ignore_errors: True
failed_when: false
retries: 5
delay: 2
with_items: "{{ haproxy_gpg_keys }}"