Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: I7fa0a2928bb32bc20ed4087c9d1e9ba2adcb42a6

defaults/main.yml

@@ -16,9 +16,10 @@
 ## Verbosity Options
 debug: False
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # Options are 'present' and 'latest'
 barbican_package_state: "latest"
+barbican_pip_package_state: "latest"
 
 # Toggle keystone authentication for barbican
 barbican_keystone_auth: no

tasks/database-setup.yml

@@ -17,3 +17,4 @@
   command: "{{ barbican_bin }}/barbican-manage db upgrade"
   become: yes
   become_user: "{{ barbican_system_user_name }}"
+  changed_when: false

tasks/init_upstart.yml

@@ -23,6 +23,5 @@
   register: upstart_init
 
 - name: Reload init scripts
-  shell: |
-    initctl reload-configuration
+  command: initctl reload-configuration
   when: upstart_init | changed

tasks/install.yml

@@ -30,7 +30,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ barbican_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ barbican_pip_package_state }}"
     extra_args: >-
       {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }}
       {{ pip_install_options | default('') }}
@@ -104,7 +104,7 @@
 - name: Install pip packages
   pip:
     name: "{{ barbican_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ barbican_pip_package_state }}"
     virtualenv: "{{ barbican_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: >-

tasks/main.yml

@@ -28,6 +28,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always