Fix usage of "|" for tests

With the more recent versions of ansible, we should now use
"is" instead of the "|" sign for the tests.

This should fix it.

Change-Id: I52808859f84e18c5f906dd7bcf2e30a9a155de99

handlers/main.yml

@@ -23,7 +23,7 @@
   with_dict: "{{ designate_services }}"
   when: "item.value.group in group_names"
   register: _stop
-  until: _stop | success
+  until: _stop is success
   retries: 5
   delay: 2
   listen: Restart designate services
@@ -55,7 +55,7 @@
   with_dict: "{{ designate_services }}"
   when: "item.value.group in group_names"
   register: _start
-  until: _start | success
+  until: _start is success
   retries: 5
   delay: 2
   listen: Restart designate services

tasks/designate_install.yml

@@ -32,7 +32,7 @@
     update_cache: "{{ (ansible_pkg_mgr in ['apt', 'zypper']) | ternary('yes', omit) }}"
     cache_valid_time: "{{ (ansible_pkg_mgr == 'apt') | ternary(cache_timeout, omit) }}"
   register: install_packages
-  until: install_packages|success
+  until: install_packages is success
   retries: 5
   delay: 2
 

tasks/designate_install_source.yml

@@ -41,7 +41,7 @@
   file:
     path: "{{ designate_bin | dirname }}"
     state: absent
-  when: designate_get_venv | changed
+  when: designate_get_venv is changed
 
 - name: Create designate venv dir
   file:
@@ -49,14 +49,14 @@
     state: directory
     mode: "0755"
   register: designate_venv_dir
-  when: designate_get_venv | changed
+  when: designate_get_venv is changed
 
 - name: Unarchive pre-built venv
   unarchive:
     src: "/var/cache/{{ designate_venv_download_url | basename }}"
     dest: "{{ designate_bin | dirname }}"
     copy: "no"
-  when: designate_get_venv | changed
+  when: designate_get_venv is changed
   notify:
     - Restart designate services
 
@@ -71,7 +71,7 @@
       {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }}
       {{ pip_install_options | default('') }}
   register: install_packages
-  until: install_packages|success
+  until: install_packages is success
   retries: 5
   delay: 2
   when: designate_get_venv | failed or designate_get_venv | skipped
@@ -85,7 +85,7 @@
   when:
     - ansible_pkg_mgr in ['yum', 'dnf', 'zypper']
     - not designate_developer_mode | bool
-    - designate_get_venv | changed
+    - designate_get_venv is changed
 
 # NOTE(odyssey4me):
 # We reinitialize the venv to ensure that the right
@@ -103,7 +103,7 @@
         --no-pip \
         --no-setuptools \
         --no-wheel
-  when: designate_get_venv | changed
+  when: designate_get_venv is changed
   tags:
     - skip_ansible_lint