openstack
/
openstack-ansible-os_magnum
Code Issues Proposed changes

Remove 'ignore_errors: true' in favor of 'failed_when: false' 

This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.

It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.

Change-Id: Ib906fa3a67a8d70174da10608921a1a213dfd739
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
(cherry picked from commit 14df603af3)
This commit is contained in:
Kevin Carter 2016-10-14 16:45:43 -05:00 committed by Jesse Pretorius (odyssey4me)
parent 22de6a657b
commit 1aae6c283e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tasks/install.yml
View File

@ -64,7 +64,7 @@
url: "{{ magnum_venv_download_url }}"
dest: "/var/cache/{{ magnum_venv_download_url | basename }}"
force: yes
ignore_errors: true
failed_when: false
register: get_venv
when:
- not magnum_developer_mode | bool