Use package module to install distro packages
Consolidate distro package install tasks into a single task using the package module and pass the package list into the name instead of using a with_items loop. The minimum Ansible version is raised to 2.2 due to a known bug [1] in Ansible's apt module which does not update the cache properly if the cache update and the install are combined in a single task. [1] https://github.com/ansible/ansible-modules-core/issues/1497 Change-Id: I5d87e5e5d11bd1dcffb6a6187733f6d8e4e72fbf
This commit is contained in:
parent
20b74b2098
commit
edd2093370
|
@ -23,7 +23,7 @@ galaxy_info:
|
|||
description: "Openstack Monasca"
|
||||
company: "Internet Solutions"
|
||||
license: "license (Apache)"
|
||||
min_ansible_install: 1.9
|
||||
min_ansible_install: 2.2
|
||||
platforms:
|
||||
- name: Ubuntu
|
||||
versions:
|
||||
|
|
|
@ -16,9 +16,16 @@
|
|||
# (c) 2016 Donovan Francesco <donovan.francesco@is.co.za>
|
||||
# (c) 2016 Paul Stevens <paul.stevens@is.co.za>
|
||||
|
||||
- include: monasca_install_apt.yml
|
||||
static: no
|
||||
when: ansible_pkg_mgr == 'apt'
|
||||
- name: Install distro packages
|
||||
package:
|
||||
name: "{{ monasca_distro_packages }}"
|
||||
state: "{{ monasca_package_state }}"
|
||||
update_cache: "{{ (ansible_pkg_mgr == 'apt') | ternary('yes', omit) }}"
|
||||
cache_valid_time: "{{ (ansible_pkg_mgr == 'apt') | ternary(cache_timeout, omit) }}"
|
||||
register: install_packages
|
||||
until: install_packages | success
|
||||
retries: 5
|
||||
delay: 2
|
||||
|
||||
- name: Create developer mode constraint file
|
||||
copy:
|
||||
|
|
|
@ -1,26 +0,0 @@
|
|||
---
|
||||
# Copyright 2016, Walmart Stores, Inc.
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||
# you may not use this file except in compliance with the License.
|
||||
# You may obtain a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
# See the License for the specific language governing permissions and
|
||||
# limitations under the License.
|
||||
|
||||
- name: Install apt packages for monasca
|
||||
apt:
|
||||
pkg: "{{ item }}"
|
||||
state: "{{ monasca_package_state }}"
|
||||
update_cache: yes
|
||||
cache_valid_time: "{{ cache_timeout }}"
|
||||
register: install_monasca_distro_packages
|
||||
until: install_monasca_distro_packages |success
|
||||
retries: 5
|
||||
delay: 2
|
||||
with_items: "{{ monasca_distro_packages }}"
|
Loading…
Reference in New Issue