openstack
/
openstack-ansible-os_nova
Code Issues Proposed changes

Remove unnecessary package install duplication 

Currently the devel packages are installed everywhere,
but they only need to be where the wheels are built.

Also, there is already a task to install the packages
needed on the target hosts when installing - so we do
not need to give the same list to the venv install role
because they will already have been installed.

Change-Id: Iab434e8c91463d9b0c34eba23b0550fa2af46481
This commit is contained in:
Jesse Pretorius 2018-10-30 19:05:08 +00:00
parent 9b0f1b2775
commit e8de852a54
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tasks/nova_install_source.yml
View File

@ -42,7 +42,6 @@
vars:
venv_build_distro_package_list: "{{ nova_devel_distro_packages }}"
venv_install_destination_path: "{{ nova_bin | dirname }}"
venv_install_distro_package_list: "{{ nova_distro_packages }}"
venv_pip_install_args: "{{ nova_pip_install_args }}"
venv_pip_packages: >-
{{ nova_pip_packages +

1
vars/source_install.yml
View File

@ -45,7 +45,6 @@ nova_package_list: |-
{% if nova_oslomsg_amqp1_enabled | bool %}
{% set _ = packages.extend(nova_compute_oslomsg_amqp1_distro_packages) %}
{% endif %}
{% set _ = packages.extend(nova_devel_distro_packages) %}
{{ packages }}
_nova_bin: "/openstack/venvs/nova-{{ nova_venv_tag }}/bin"