The use of pidfiles seems to be one which causes much debate [1] and
debain buster no longer creates a pidfile for rsyslog so the tests
in this role which rely on it are broken.
Given that systemd now knows the process pid and more distros are
likley to drop the use of the pidfile, and also that the rsyslog
functionality in OSA is largely replaced with systemd journal
remote forwarding, we can remove these tests that break without a
pidfile.
[1] https://github.com/rsyslog/rsyslog-pkg-ubuntu/issues/79
Change-Id: Ia2be525c75fb8bbc549cbc3aa53b3c0db05002fa
Now that run_tests.sh handles the tests repo clone, we can
remove the use of the older tests-repo-clone.sh script.
Change-Id: I5dd34c9eb8a7a18462a90c68c7345920291094c8
Should fix the issues:
- ANSIBLE0012 Commands should not change things if nothing needs doing
- ANSIBLE0011 All tasks should be named
Change-Id: Ia6ecb913065eb09564ca3bf6be07bb03746dd838
This patch implements an initial set of jobs intended to match
the current job execution method. It does not intend to improve
how the jobs are executed - only to replicate what is currently
in openstack-infra/openstack-zuul-jobs and provide the platform
to iterate on.
Change-Id: I8cae14c37422a5eb4b9580b0a8220ddfa5cb6053
When executing the tests repo clone in OpenStack-CI,
use zuul-cloner instead of git to enable cross-repo
testing. This ensures that if a dependent patch from
the tests repo is noted using 'Depends-On: <change-id>'
in the commit message, that patch will be included.
Depends-On: Idce7abebf32f24c356a27e099fbca954d917402b
Depends-On: I5da7802d61d2ab6b03908138e3a3ed2db22e3d29
Change-Id: I00c8e04c091177bc5c1692257204d6aac89c0bbc
Add 'become' and root 'user' options to the playbook instead of using
'ansible_become' through an inventory variable.
Change-Id: I5f47dbb71cae8c61f1f814c1e9dfcb2d28e14b3f
Added rsyslog restart handlers to each rsyslog_server_post_install task.
There was an issue when rsyslog_post_install would stop its service,
it would automatically get restarted and the service would not listen
for incoming logs. This now ensures that the rsyslog service will
be restarted after configuration files are changed.
Add rsyslog_pid_name to variable files for distrubition changes for rsyslogd pid
Change-Id: I757387e8f7f7209b1ab928208894ecf4bf510efc
Partial-Bug: 1636017
This patch consumes the test scripts implemented by
https://review.openstack.org/375061 to ensure that
the tests and test preparation is consistent and
more maintainable.
Change-Id: I38775ca18db04be8bcc40df8bb6194fcfa0e5adf
This fix separates the remote log streams from the local
by binding the remote ruleset to the UDP and TCP input modules.
Additionally new overrides are provided to allow for better customization:
``rsyslog_server_logrotation_window`` defaults to 14 days
``rsyslog_server_ratelimit_interval`` defaults to 0 seconds
``rsyslog_server_ratelimit_burst`` defaults to 10000
The rsyslog.conf is also now using v7+ style configuration settings
Change-Id: I5759ea8fb7eaad79d857a335a4aede558aa0067d
Closes-Bug: #1621559
This patch updates the tox.ini the same bashate exceptions as are
currently in the OpenStack-Ansible playbook repo.
It also ensures that the linters and all lint targets work
appropriately and normalises the tox.ini configuration to use
uniform formatting.
The use of ansible.cfg is removed as there is no way of being
certain which paths can be used without reverting to an ugly
sed hack in the commands. This is why it is preferred to make
use of environment variables which make use of tox's default
substitutions instead. It's a more reliable way of achieving
the goal for the purpose of gating and testing.
The switch to using a git clone instead of ansible-galaxy to
download the plugins is due to the path spec not being able to
work in Ansible 2.x. [1]
[1] https://github.com/ansible/ansible/issues/13563
Change-Id: I2d5156028a9edc915f8d9a665d19e5a6e1728fb0
Dmitriy Rabotyagov