ansible-lint 5.0.9 has merged our NoLogPasswordRule [1]
APTRepositoryCacheUpdateRule is not relevant since
ansible fix has been merged for several years now.
Also ansible-lint provides yamllint check.
This means, we shouldn't really carry custom lint
rules and can jsut use upstream ones.
We also update ansible and collections version to
match with the integrated repo.
[1] 8bef056d69
Change-Id: Ie85d6d0a17849bbc665a7f49644c38b5f6a96bb2
With the more recent versions of ansible, we should now use
"is" instead of the "|" sign for the tests.
This should fix it.
Change-Id: Ida90a5a717adaf07ebf2ee6f04136fe920cfe46b
Lint rule to make sure no module argument looking like "password"
will get logged.
Change-Id: I180b77faf7aaab57d1c48fc993e43f08c4fb16f6
Closes-Bug: #1760878
The custom ansible-lint rule APTRepositoryCacheUpdateRule was added in
67bfc90703, this change adds tests to
validate its functionality.
Change-Id: Ie0642cc41c016fc016b2bc6fc6d04b6afdf2be2c
Partial-bug: 1750656
This rule is designed to prevent the Ansible module `apt_repository`
from being used to update the APT cache. There is a bug [1] in
`apt_repository` that prevents cache updates from being performed
whenever the module is retried. If the cache update fails at the first
attempt, it is skipped on the subsequent attempt of the task causing the
task to always complete successfully. Until this bug is addressed this
rule should prevent it from being introduced into OpenStack-Ansible.
Partial-bug: 1750656
[1] https://github.com/ansible/ansible/issues/36605
Change-Id: If440ce129c31fb4e62a8e0ac5094195f4d4d7167
In some part in the code we import objects. In the Openstack style guidelines
they recommend to import only modules. [1]: "Do not import objects, only modules".
[1] https://docs.openstack.org/hacking/0.10.3/
Change-Id: I55ec09ba2977a973d384d6387958ec0972f581ec
This patch adds a new linter that ensures packages are being
passed as a list rather than using with_items. It also adds a
test for the new linter and adds the test to the existing linter
CI job script.
Change-Id: Iffd7284fb1c7cc41df2a4e271821e51bb274c3a3
This patch adds a new linter that ensures packages are being
passed as a list rather than using with_items. It also adds a
test for the new linter and adds the test to the existing linter
CI job script.
Change-Id: Iffd7284fb1c7cc41df2a4e271821e51bb274c3a2
Signed-off-by: Major Hayden <major@mhtx.net>
Added custom style rules checker that checks whether the
playbooks follow YAML dictionary format or not.
Guidelines for writing Ansible playbooks is located here:
http://docs.openstack.org/developer/openstack-ansible/
developer-docs/contribute.html#ansible-style-guide
Change-Id: I9ad0d90017a0ce38f97dcbd43cbe8c1c13f185ed
Closes-Bug: 1629033
Dmitriy Rabotyagov