nova: restart instead of reloading services

There is a bug inside oslo.service which causes calls a stop,
reset and start instead of reset only on SIGHUP which causes
a very inconsistent state of services.

Until this is resolved, we should not reload services but restart
them only.  This patch should be reverted once the related bug
is fixed.

Depends-On: If53b59f3faede91e158cd544742ab37639800b57

Change-Id: I61e340a4ef5f0980e8c36611c0f78cd06946636b
Related-Bug: #1715374
(cherry picked from commit 817c95fdac)

playbooks/os-nova-install.yml

@@ -118,7 +118,14 @@
       include: common-tasks/restart-service.yml
       vars:
         service_name: "nova"
-        service_action: "reloaded"
+        # NOTE(mnaser): There is a bug in oslo.service which actually restarts
+        #               the entire service instead of resetting it, but it
+        #               leaves Nova in a broken state.  This should be moved
+        #               to "reloaded" once it's resolved.
+        #
+        #               https://bugs.launchpad.net/openstack-ansible/+bug/1715374
+        #
+        service_action: "restarted"
         service_negate: "{{ ['nova-placement-api.service', 'nova-novncproxy.service', 'nova-spicehtml5proxy.service' ] + nova_service_negate | default([]) }}"
       when:
         - "nova_all_software_updated | bool"