* Update charm-nova-compute from branch 'master'
to b57593f86dc0627d74a9264a9035a2c67fd69c01
- Add support for the 'cpu_models' option in nova.conf
Since OpenStack Train release the 'cpu_models' config option
has superseded the 'cpu_model' config option in the nova.conf.
This patch adds support for the new 'cpu_models' allowing a user
to provide a comma separated list of supported, named CPU models.
This patch also includes a unit test for the cpu_mode='custom'.
Closes-bug: #2025914
Change-Id: I30328abc07d3304f1bfb67c81360fb5229214c97
* Update charm-nova-compute from branch 'master'
to 31df8c6bf2711fd0d82ad4d9c866ab6e0845de14
- Add storage-backend subordinate relation
Implement initial support for container-scoped storage-backend
relation to integrate nova-compute with storage providers.
Transition to blocked state if multiple storage backend
relations are connected
Change-Id: I03e67731df0263887d2d0f671750f420d6e62c1c
* Update charm-nova-compute from branch 'master'
to f3bf6be831880eb9a939674252ece9a5cc964847
- Updates for caracal testing support
These updates, on the master branch, are to support testing the caracal
packages and support of the charms for caracal. They do NOT lock the charms
down, and don't change the testing branches to stable branches.
Change-Id: Ib7947ab8dfd4c4b18c482f4df1a7c6f5b5e3756f
* Update charm-nova-compute from branch 'master'
to ab35c611651e831b217e68fea682c729881e38f7
- Merge "AppArmor policy update for NVMeoF"
- AppArmor policy update for NVMeoF
When using NVMeoF feature with nova-compute apparmor in enforce
mode, nova-compute is denied from running /usr/sbin/nvme and
/usr/sbin/blkid, and reading /etc/nvme/hostnqn.
Change-Id: Ia23fbf341d5b7ad469337d8a0c65c18ec519a891
Closes-Bug: #2039161
* Update charm-nova-compute from branch 'master'
to 650f3a5d511690ec27648b30f3b24532378a33a1
- [v2] Fix migration across nova-compute apps using ceph
This change reworks previous changes [1] and [2] that had
been respectively reverted and abandoned.
When using the config libvirt-image-backend=rbd, VMs
created from image have their disk data stored in ceph
instead of the compute node itself.
When performing live-migrations, both nodes need to
access the same ceph credentials to access the VM's
disk in ceph, but this is currently not possible
if the nodes involved pertain to different
nova-compute charm apps.
This patch changes app name sent to ceph to
'nova-compute-ceph-auth-c91ce26f', a unique name common to
all nova-compute apps, allowing all nova-compute apps to
use the same ceph auth.
This change also ensures newly deployed nodes install
the old credentials first on ceph-joined hook,
and then supercedes it with the new credentials
on ceph-changed hook, therefore also retaining
the old credentials.
This patch also includes the charmhelpers sync
from PR: #840
[1] https://review.opendev.org/889642
[2] https://review.opendev.org/896155
Closes-bug: #2028559
Related-bug: #2037003
Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1149
Change-Id: I1ae12d787a1f8e7761ca06b5a80049c1c62e9e90
* Update charm-nova-compute from branch 'master'
to 4d6f4c07c9b634e22d5445a702be3d3ee9730ab3
- Update apparmor profile for nova-compute
Nova-compute uses ssh and scp commands extensively and this
patch allows the process to read the configuration too in
/etc/ssh/ssh_config.d/ directory.
Closes-Bug: #2044983
Change-Id: I336ce64d493c549096d0b8706996e0f17a2728fb
* Update charm-nova-compute from branch 'master'
to d90d6ee847df92e17f103ac470465259cca80572
- Improve platform mocking
Patch out charmhelpers.osplatform.get_platform() and
charmhelpers.core.host.lsb_release() globally in the unit tests to
insulate the unit tests from the platform that the unit tests are being
run on.
Change-Id: I33d473d83a7c8f4f23840b6b6bcf153ed423ccdc
* Update charm-nova-compute from branch 'master'
to e70f228916adfc80bd9870de58b7cb54d88ca51a
- Merge "Revert "Fix migration across apps when using VMs created from image""
- Revert "Fix migration across apps when using VMs created from image"
This reverts commit c3c2cf0349c086dad7f23b180c3ee9ea0f865e8f.
Reason for revert: This introduces an undesired behavior when scaling-out that needs to be addressed in a complementary patch.
Change-Id: I21c127aa565e489ba4d93a1efc8ddba63ef32e87
* Update charm-nova-compute from branch 'master'
to ccea3ee4673261368262ac8cf9ee6b429d0db73e
- Merge "Fix migration across apps when using VMs created from image"
- Fix migration across apps when using VMs created from image
When using the config libvirt-image-backend=rbd, VMs
created from image have their disk data stored in ceph
instead of the compute node itself.
When performing live-migrations, both nodes need to
access the same ceph credentials to access the VM's
disk in ceph, but this is currently not possible
if the nodes involved pertain to different
nova-compute charm apps.
This patch changes app name sent to ceph to 'nova-compute',
allowing all nova-compute apps to use the same ceph auth.
This patch also includes the charmhelpers sync
from PR: #840
Closes-bug: #2028559
Change-Id: I7222661017655fd7225db0c677f1a8f5ebb7984d
* Update charm-nova-compute from branch 'master'
to f6892d228c6e6eff72bbfc700a4d5a4a9a4d92e7
- Merge "Do not manage subordinate service restarts"
- Do not manage subordinate service restarts
The subordinate charms should manage the services that
they deploys and configure, not the principle they are related to.
This change switches the approach for restarting services
from having the nova-compute charm doing it directly to having
nova-compute triggering the restart by request a restart down
the existing relations.
Closes-Bug: #1947585
Change-Id: I7419e39d68c70d21a11d03deeff9699421b0571e
* Update charm-nova-compute from branch 'master'
to cc7ffa9884320dd60de8fdd60f79a5ffbcfbb947
- Merge "Drop the path from the auth_url."
- Drop the path from the auth_url.
The template previously could use v2.0 depending on the value of
api_version. This was causing issues in newer releases of OpenStack
where the value of api_version was reporting as something other than
"3", and the generated Ironic config tried to use the v2.0 Keystone API.
This patch removes the optional logic in the template for v2.0 and rely
on the global default just like templates/parts/section-placement does.
Closes-Bug: #1995778
Change-Id: I8e0270b933f9c8fb5d6a65f9ebb930a0b21fead8
* Update charm-nova-compute from branch 'master'
to c1115f4c5a1ec3b701a8a5d60c85389ad15e53d4
- Merge "Set nova config for rbd instance folder cleanup after evacuations"
- Set nova config for rbd instance folder cleanup after evacuations
After evacuations and revert resizes when using rbd storage backend,
the instance folder is usually left behind and causes issues when
migrating the instance back to the host.
With the config option set, the nova-compute service will cleanup
those folders as part of the periodic checks that run for instances
that have been evacuated/migrated.
Closes-bug: #2019141
Change-Id: I846ccb0a95d04139b41fdad6cbf465d303d6cc09
* Update charm-nova-compute from branch 'master'
to 71df10c44b0868e3b952ec534de59c2f9b0378bb
- Merge "Add docs key and point at Discourse"
- Add docs key and point at Discourse
Add the 'docs' key and point it at a Discourse topic
previously populated with the charm's README contents.
When the new charm revision is released to the Charmhub,
this Discourse-based content will be displayed there. In
the absense of the this new key, the Charmhub's default
behaviour is to display the value of the charm's
'description' key.
Change-Id: I73c3ffa7632bbb2903b9c81d94af7dabae0b19da
* Update charm-nova-compute from branch 'master'
to 1e4112d1d68741fb479d5012026c7b9940ee8d68
- Use service_domain in [service_user] section
Sync from charm-helpers to update [service_user] config to use the
service domain.
The keystone charm currently creates two service users, one for the
service domain (for v3 authentication), and the other for the default
domain (for v2 authentication). The [service_user] config needs to
use the service domain.
Closes-Bug: #2026202
Change-Id: Ia1329a6c53cc4b532436751f0396149139a88172
* Update charm-nova-compute from branch 'master'
to 3c53110282b97c42a00cee9ee344f32dc8cf29c5
- Add support for using service tokens
This patch configures Nova to send a service token along with the
received user token on requests to other services. This can allow those
other services to accept the request even if the user token has been
invalidated since received by Nova. Also with this patch Nova will
accept request from other services with invalid user tokens but valid
service tokens. Service tokens exist since Openstack Queens.
Closes-Bug: #1992840
Change-Id: I78b43ef77dc1d7b5976ec81ecddf63c9e6c8b6c1
* Update charm-nova-compute from branch 'master'
to d9fc4b69c11464525c38e5f2f6a5e9003d0d4b4e
- Enable jammy-antelope voting and drop kinetic-zed tests
* Voting was turned on for jammy-antelope in the
project-template for charm-functional-jobs in zosci-config
* Voting for jammy-antelope bundles with non-standard names
is turned on in individual charms
* Kinetic-zed bundles/tests are removed
Change-Id: Ic290801451f6537e25dfb0330a81598bbafa7135
* Update charm-nova-compute from branch 'master'
to cc5d6234c7060241068d48b47be0f43375cf2b7b
- Sync with charm-helpers
This sync includes this patch to charm helpers:
https://github.com/juju/charm-helpers/pull/757
which is an extension of this one:
https://github.com/juju/charm-helpers/pull/740
and both are meant to include templates to configure service tokens
in juju charms as shown in this lp bug:
Related-Bug: #1992840
Change-Id: I5a5564f3e50fc09dc905b6a8f49256886d3c6a69
* Update charm-nova-compute from branch 'master'
to 7e3ead3389b3824ba2a9fb5467cf03869cd59fb2
- Adding mke2fs to apparmor
This is needed as all mkfs.* variants end up calling mke2fs.
Closes-bug: #2008391
Related-Bug: #1960231
Change-Id: I940bf0ca9cd330ae0b45b53d0d19844806a4bbbb
* Update charm-nova-compute from branch 'master'
to ce62f79a482f5db53b46cea79d11f899244f826b
- Merge "Use a stable hostname to render nova.conf"
- Use a stable hostname to render nova.conf
OVS introduced a new service called ovs-record-hostname.service which
records the hostname on the first start in the ovs database to identify
the ovn chassis, this is how it achieved a stable hostname and be
resilient to the changes in the FQDN when the DNS gets available.
This change introduces the same approach for nova-compute charm. In the
first run of the NovaComputeHostInfoContext the value passed in the
context as host_fqdn is stored in the unit's kv db, and re-used on every
subsequent call.
This change affects only new installs since the hint to store (or not)
the host fqdn is set in the install hook.
Change-Id: I2aa74442ec25b21201a47070077df27899465814
Closes-Bug: #1896630
* Update charm-nova-compute from branch 'master'
to 4a26466235b987a2d4237bbd51819ec7728cd9d0
- Merge "Refactor unit tests to avoid leaks of mocks."
- Refactor unit tests to avoid leaks of mocks.
It was found that the modules test_actions_openstack_upgrade and
test_actions_package_upgrade were mocking different classes and
functions right before importing the modules under test
(openstack_upgrade and package_upgrade respectively), although these
mocks weren't being reset making tests executions coming after them to
get benefitted (or impacted) by the mocks in memory.
This patch takes advantage of mock.patch() decorator at the class level
and importlib.reload() to make sure the mocks don't outsurvive the
module.
When the teardown was in place it was found a different set of functions
that were relying on that mocking, so they were patched to allow the
tests run in the expected (mock'ed) environment.
Summary of changes:
- Move get_availability_zone() to contexts module, nova_compute_utils
depends on nova_compute_context, the latter shouldn't be importing
code from the former since it breaks the layering, even when the
import is being done within a function's body.
- Mock env variable JUJU_UNIT_NAME per test case, the tests defined
in the test_nova_compute_utils and test_nova_compute_contexts were
relying on the leakage of mocks set by other test modules, this
makes them run in an isolated fashion.
- Move update_nrpe_config testing to its own class, the main class
NovaComputeRelationsTests mocks the function update_nrpe_config()
making it difficult to test it in a test method, hence making the
test part of its own class it's posible to not mock the function
and correctly runs its implementation.
- Teardown mocks made at import level.
Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/997
Change-Id: I4468ef1a0619befc75c6af2bad8df316125a7cf5
* Update charm-nova-compute from branch 'master'
to 046a9169c2b3781084f9401719ce498bfedacbf7
- Sync with charm-helpers
Change-Id: I45f120c455881a0fa879812563b805dadbf666fc
* Update charm-nova-compute from branch 'master'
to 98191ea5bf442a712f3e575bf1a7d4bb59dd3614
- Make virt_mkfs configurable with ext4 default
Closes-Bug: #1960231
Change-Id: Ia2ac7318f1164a9015bdf9e7ce7d20a129e22af4
* Update charm-nova-compute from branch 'master'
to 83497e833d2d76687868552ef84db1906472fd6f
- Use enabled option for vnc
vnc_enabled, novnc_enabled are depreacted but should
be in DEFAULT section. Commit [1] moved the deprecated
options under vnc group so they dont have any effect.
This leads to vnc as True which is default option
in nova.
Change the template to use enabled option instead of
deprecated ones
[1] 73edc4f817
Closes-Bug: #1998300
Change-Id: I4193c042f6b3a55dfb1dc57f0f4d3bc71e19006f
* Update charm-nova-compute from branch 'master'
to 966e522dc5dad7ac5f5c2b6756bfe468c5c9941e
- Upin the versions of tox
Unpin the versions of tox, setuptools, etc. This removes the issue
with tox 4.x breaking the virtualenv dependencies.
Change-Id: I103e16c70aee394331b37ec0cf323e014011d3ae
* Update charm-nova-compute from branch 'master'
to a3da54fb4156fa93ea89baefa47c2032edb9423e
- Move default_ephemeral_format to [DEFAULT] section
The default_ephemeral_format line in nova.conf was not in the [DEFAULT]
section in the templates and has therefore been ignored ny nova-compute.
This change moves it to the correct section for all releases.
Closes-Bug: #1992386
Change-Id: Idc0602f95e5378be1243926aa88dc7b5282ee844
* Update charm-nova-compute from branch 'master'
to 6a710c86a394584a8bfa955713f1f9653f6e0607
- [s390x] Set pointer_model to ps2mouse
On s390x environments there is no usb controller, hence the default
pointer model (usbtable) produces failures when launching new instances
with the following error:
unsupported configuration: USB is disabled for this domain,
but USB devices are present in the domain XML
Change-Id: I58f7f1148096d703384e089292959718fd413157
Closes-Bug: #1962381
* Update charm-nova-compute from branch 'master'
to f414dbdf0a002e075ef11be798e873f962c51199
- Update testing bundles.
- Drop extra-repositories from jammy-zed bundle. The repository
ppa:openstack-charmers/swtpm is only needed when running on Focal,
the Ubuntu Archive >= Jammy contains the needed packages.
- Drop 'source' config key from rabbitmq-server and
mysql-innodb-cluster. The infrastructure support charm are sourced
from 'distro' and they don't need to configure an UCA source.
Change-Id: Ia60e46b8b2d35034767a2932176ec799c2e086bf
Closes-Bug: #1994055
* Update charm-nova-compute from branch 'master'
to d031a489a7344f5f799bd9fbe5c55d10ceecd0f6
- Add Kinetic and Zed support
* sync charm-helpers to classic charms
* change openstack-origin/source default to zed
* align testing with zed
* add new zed bundles
* add zed bundles to tests.yaml
* add zed tests to osci.yaml and .zuul.yaml
* update build-on and run-on bases
* add bindep.txt for py310
* sync tox.ini and requirements.txt for ruamel
* use charmcraft_channel 2.0/stable
* drop reactive plugin overrides
* move interface/layer env vars to charmcraft.yaml
Change-Id: I506c53b4956024066bc769665525cb022438a0ae
* Update charm-nova-compute from branch 'master'
to 467fa1b8e941daa48551174118fdf5f589fadcd7
- Merge "Update nova.conf for OpenStack Yoga"
- Update nova.conf for OpenStack Yoga
This merge request focuses on fixing the VNC config for OpenStack Yoga
on the Focal and Jammy series. Originally, the Yoga version of this
charm was using a template nova.conf file from Train which did not use
the new [vnc] required for Yoga. Train had the VNC config in the
[DEFAULT] section, which is depreciated in Yoga.
Itemized changes to charm below:
* Create templates/yoga
* Move VNC config to [vnc] section in nova.conf
* Rename VNC config keys to follow the Yoga specification.
Closes-Bug: #1974082
Closes-Bug: #1734683
Change-Id: Ic100528f9f38bbc0c83e4f563166113024e3db59
* Update charm-nova-compute from branch 'master'
to 960520b1992ca43aa26a161dca7621bebcbb7b63
- Pin tempest for different python versions
Change-Id: I236ed757a93c7f3bb1942eb16ed859999f8fd318
* Update charm-nova-compute from branch 'master'
to fadbf178fd4f27314c75ef384ff96f29fa607a41
- Replace deprecated assert_ with assertTrue
The assert_ method alias has been deprecated in unittest since version 3.2[1].
[1] https://docs.python.org/3/library/unittest.html#deprecated-aliases
Change-Id: I7aa4862c93feb0d6be2e3080a6689d49ca756cc3
* Update charm-nova-compute from branch 'master'
to cf0f464391df509e752c6010964efe2aca10ef89
- AppArmor policy update for os-brick and iSCSI
In iSCSI usecases including cinder-lvm, os-brick requires lock files
such as:
- /run/lock/nova/os-brick-connect_volume
- /run/lock/nova/os-brick-connect_to_iscsi_portal-192.168.0.1
and lsscsi requires following access to compose a rescan command such as
"/sys/bus/scsi/drivers/sd/2:0:0:0/rescan":
- /dev/
- /sys/bus/scsi/devices/
Closes-Bug: #1979812
Related-Bug: #1939390
Change-Id: Id2db3a70b8d1287bda006f1bbc5442038f7070f1
* Update charm-nova-compute from branch 'master'
to da2142cca38fb5b5f326473f1cebcd99d2e44408
- Merge "Add package-upgrade action"
- Add package-upgrade action
The package-upgrade action performs package upgrades for the current
OpenStack release.
The code path used is similar to the openstack-upgrade action, with the
difference being that package-upgrade will not execute if an openstack
upgrade is available (based on the openstack-origin setting).
This change includes a charm-helpers sync.
Change-Id: I88ccffad7af2d2e9cddc1f6514ebd07898e117dc
* Update charm-nova-compute from branch 'master'
to f6c536baec29a34b79a13708f2f0b82dd0db0530
- Render correct driver in nova-compute.conf
Commit abe5a289 fixed the rendering of the ironic driver in the
nova-compute.conf file for OpenStack versions >= Wallaby. However, it
always renders the nova-compute.conf file for train and above, which is
hard-coded to the Ironic libvirt driver.
This adds additional templating logic to the nova-compute.conf driver in
order to render the correct driver to use.
Related-Bug: #1968547
Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
* Update charm-nova-compute from branch 'master'
to 7e362f3482de84682124fb0f3897540a71f2ee24
- Merge "Only render qemu.conf for hypervisors using qemu"
- Only render qemu.conf for hypervisors using qemu
Change-Id: I02a250c27d1b52d5cc9df3f1d6256bfc3ab982ea
Closes-Bug: #1968547
* Update charm-nova-compute from branch 'master'
to 01c0ce85068c288225385309344da5d5b9f4cd36
- Update apparmor profiles for Jammy/Yoga
The apparmor profile is missing some updates for versions on Jammy/Yoga.
Add read access to /proc/*/limits and some updates for sudo access.
Additionally, needed to move /var/lib/contrail access rule to be
alphabetically sorted.
Change-Id: I9b7175470f84515fb15715324bf1d8887dd5791f
* Update charm-nova-compute from branch 'master'
to afe8ba719f6310e33d99431ce350b9ec92696b15
- Updates to enable jammy and finalise charmcraft builds
- Add 22.04 to charmcraft.yaml
- Update metadata to include jammy
- Remove impish from metadata
- Update osci.yaml to include py3.10 default job
- Modify tox.ini to remove py35,py36,py37 tox target and add py310
target.
- ensure that the openstack-origin is yoga
Change-Id: I62d95763a6283d8dc7f54b65b0474d48b20608f0
* Update charm-nova-compute from branch 'master'
to d53aa79b968d3d35b022e0cc20686abb9dfa5a73
- Merge "Enable vTPM support in nova-compute"
- Enable vTPM support in nova-compute
Enable vTPM support in nova-compute charm. This adds new packages to be
installed swtpm and swtpm-tools as well as updates the nova-compute.conf
file and the qemu.conf file to set appropriate user/groups for swtpm.
func-test-pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/696
Change-Id: Idf0d19d75b9231f029fa6a7dc557d2a9ee04915b
* Update charm-nova-compute from branch 'master'
to 958e0546948731aca6650d4504a9ed7196d1b30e
- Allow access to secure uuidd socket
Nova uses python libraries, which uses libuuid in order to generate
UUIDs. The apparmor profile does not allow for the nova-compute service
to access the /run/uuidd/request socket in order to generate a secure
UUID. Update the apparmor profile to allow nova to use the uuid service.
Closes-Bug: #1958689
Change-Id: I2ec6e7aba5c84c697733227ce36f762e4787cce1
* Update charm-nova-compute from branch 'master'
to f4eeb0650ae548257e613c772e806b6b4748c4fa
- Allow read access to firmware information
Update the apparmor profile for nova-compute to allow it to read the
firmware configuration information for qemu. This is necessary in order
to launch instances using UEFI when apparmor enforcement is enabled.
Closes-Bug: #1958686
Change-Id: I7d9152dcc684923600c40ff0227c3c3eaafa7574
* Update charm-nova-compute from branch 'master'
to 330086cb71c06a0fd710a6240d90c834424217d9
- Add extra-repositories config option
Add an extra-repositories config option to nova-compute in order to
allow configuring additional apt repositories. This is useful when some
packages are not available in the distro or cloud archive.
Change-Id: Ie3b76ff3bc07b83e416c80fab1da2560d48df498
* Update charm-nova-compute from branch 'master'
to 71567080b30999f04a2a9404ffa1fed4917b7770
- Merge "Make sure lsscsi is installed for os-brick"
- Make sure lsscsi is installed for os-brick
os-brick upstream made some changes and started to use lsscsi for
discovering iSCSI devices. Make sure lsscsi is installed by the charm
until the os-brick package in Ubuntu pulls it as a dependency.
Closes-Bug: #1939390
Change-Id: I509d5edb3c6e3a4c35b7252b567a1672cf5e0bbe
* Update charm-nova-compute from branch 'master'
to 4fb655d7c377198badc8b88b1a8200262068bb9f
- Merge "Extend apparmor profile for ports in contrail"
- Extend apparmor profile for ports in contrail
This update will clear the issue where access and writing to the
port directories are denied.
journal logs showing 2 for the same port:
AVC apparmor="ALLOWED" operation="mknod" profile="/usr/bin/nova-compute" name="/var/lib/contrail/ports/bc2f6fb2-5dee-48da-b17d-10fdaeda761a" comm="python" requested_mask="c" denied_mask="c" fsuid=0 ouid=0
AVC apparmor="ALLOWED" operation="open" profile="/usr/bin/nova-compute" name="/var/lib/contrail/ports/bc2f6fb2-5dee-48da-b17d-10fdaeda761a" comm="python" requested_mask="wc" denied_mask="wc" fsuid=0 ouid=0
Signed-off-by: Arif Ali <arif.ali@canonical.com>
Change-Id: I92dbd1fa8cfacfcdc66c3ca562ac9e1c9849f9c5
* Update charm-nova-compute from branch 'master'
to 8719cbcf3005e5e5901311b211f233a2d561b1e0
- Update apparmor rules for uptime and iscsi
In the audit log we get uptime being called, and this ie being
denied read access to /proc/sys/kernel/osrelease. The first part
should fix this.
journal logs shows:
AVC apparmor="DENIED" operation="open" profile="/usr/bin/nova-compute" name="/proc/sys/kernel/osrelease" pid=2846362 comm="uptime" requested_mask="r" denied_mask="r" fsuid=64060 ouid=0
As part of allowing iscsi devices there are various files and names
in /sys/devices/virtual/block/, such that you could have dm-7/dm/name
so this should help to get this resolved.
journal log shows:
AVC apparmor="DENIED" operation="open" profile="/usr/bin/nova-compute" name="/sys/devices/virtual/block/dm-8/dm/name" pid=802673 comm="nova-compute" requested_mask="r" denied_mask="r" fsuid=64060 ouid=0
Signed-off-by: Arif Ali <arif.ali@canonical.com>
Change-Id: I40589702ac697d9e2969bcf75815ffb724a5a3ab
Marcin Wilk