* Update ironic from branch 'master'
to 1cefbbcc7508da7bf01c6c9baa6fc3e09a6a5be4
- Merge "redfish: change default virtual media storage to local storage"
- redfish: change default virtual media storage to local storage
This may be the most overridden default of Ironic, which means
we need to change the default value.
The default for ``[redfish]use_swift`` was historically ``true``,
however we've generally found that BMCs are particularlly sensitive
to extra characters in the URL as the characters may signify a
dynamically generated file, which would be problematic as virtual
media webservers also generally require range retrieval support.
This change makes the default ``false`` which should lead to one
less override for operators being necessary in practical operation.
Change-Id: Iad57b3c6423bced0e3cb6fb4e31aad6d805f26fa
* Update ironic from branch 'master'
to 3c5b4cb3498670b16d96bd926af9967f60a77ca9
- Merge "Follow-up: Use ``microversion-parse`` to parse version headers in API requests"
- Follow-up: Use ``microversion-parse`` to parse version headers in API requests
Adds a release note, unit test, and documentation update as a follow-up to the
`microversion-parse change <https://review.opendev.org/c/openstack/ironic/+/913793>`_
Change-Id: I535af988125a511e4f54c9d81acd47c327413774
* Update ironic from branch 'master'
to 27dbc24c8536a05c53b0ff93dc9f59ccf8776e4f
- Merge "Fix device_type in attach/detach vmedia for Redfish"
- Fix device_type in attach/detach vmedia for Redfish
We need to translate the generic device_type to sushy device_type
Change-Id: Id09e6f2b989513b41980c7b89c9d76edecc320db
* Update ironic from branch 'master'
to 11309e7aea08847d8f9c27afb8399117a64c61e1
- Merge "Remove redundant priority override code from service steps"
- Remove redundant priority override code from service steps
Currently, service steps are only supported as a user-requested action.
This change removes references to overriding priorities for service
steps as these overrides will have no effect and may cause confusion.
Change-Id: I35a8b59b17fdff3161df835903acec529e732c4f
* Update ironic from branch 'master'
to 7969baf58e9ae095f042e875b8944d17705ef15d
- Merge "Correct logging call in _heartbeat_service_wait method"
- Correct logging call in _heartbeat_service_wait method
Currently, _heartbeat_service_wait() is causing an error due to a
missing parameter in the call. This change resolves this issue by
removing the reference to the missing parameter.
Change-Id: I03faa67953daf282ae1b576a2a949c94a2efa973
* Update ironic from branch 'master'
to a7b2908e2c4b341e51befc15d47c445708c7c33d
- Merge "CI: Unpack cirros image partition jobs"
- CI: Unpack cirros image partition jobs
Cirros, by default, as part of its initialization, copies the initial
ramdisk contents over the filesystem on disk. This changes the partition
image creation job so we do it upfront so the partition image looks like
and matches what we generally expect from a partition image as opposed
to just a kernel, ramdisk, and bootloader.
Change-Id: Idde30e33e9453f8564a7c3b9109c4e567146dee7
* Update ironic from branch 'master'
to f494d2760adfda174cf555a718c38616f2b7fd1e
- Merge "Small Doc Fix: Moved user export for devstack guide."
- Small Doc Fix: Moved user export for devstack guide.
A small bugfix - you now need to ensure that the user env var is set before running any openstack commands (At least the ones that devstack uses)
Change-Id: I4afad7ea588cf6505a7b1186c749d13827b24290
* Update ironic from branch 'master'
to c85d9c8326a0bbd22cc41e2a27585fc51e4f5a7c
- Merge "Load machine type from command-line"
- Load machine type from command-line
Change-Id: Ib2bdac78e0eb4043e2a2f86244ea168641571817
* Update ironic from branch 'master'
to 7df06977d3e949cab81d34c9f5aebabaf6981dfe
- Merge "Add states.SERVICING and SERVICEWAIT to _FASTTRACK_HEARTBEAT_ALLOWED"
- Add states.SERVICING and SERVICEWAIT to _FASTTRACK_HEARTBEAT_ALLOWED
Currently, service steps may fail to start in scenarios dependent on IPA
fasttrack. This change attempts to resolve this by incorporating
servicing states in the fast track allowed states whitelist while also
making _FASTTRACK_HEARTBEAT_ALLOWED a superset of _HEARTBEAT_ALLOWED
instead of duplicating values in the two constants.
Change-Id: I47984469c1432e7fc7b4f1494b9f6c551c34672f
* Update ironic from branch 'master'
to d68490c6febd45e85e3aca6567326db0acdae644
- Merge "Use the new microversion-parse library to parse the version headers"
- Use the new microversion-parse library to parse the version headers
Closes-Bug: #1584718
Change-Id: Icb2e21775d1500878bb6d29f45e82e32f14332aa
* Update ironic from branch 'master'
to ddca532f52918677f4d8829a4a9d4d091b96480a
- Merge "Fix the confusion around service_reboot/servicing_reboot"
- Fix the confusion around service_reboot/servicing_reboot
We ended up using two names for the same flag (and forgot it in one
place completely). To not just fix the issue but also prevent it in the
future, refactor asynchronous steps handling into a new helper module
with constants and helper functions.
I've settled on servicing_reboot as opposed to service_reboot because
that's the value we currently set (but not read), so it provides
better compatibility when backporting.
Remove excessive mocking in the Redfish unit tests.
Change-Id: I32b5f860b5d10864ce68f8d5f1dac3f76cd158d6
* Update ironic from branch 'master'
to 3123e82a14e753a61c006f9d057c95cf0c0385be
- Merge "Fix servicing clean-up"
- Fix servicing clean-up
Serious issues:
- Nothing powers on nodes after servicing, so they end up active and
powered off in the end.
- Restoring power state was done three times.
Minor issues:
- Function _tear_down_node_servicing is called twice causing a traceback.
- Furthermore, process_event('done') is also called in another place
in deploy utils.
- Make sure nodes are never considered for fast-track when servicing, it
prevents clean-up of virtual media devices.
Change-Id: I92fd7a0009a816e93e316e4674c7509b61a474d4
* Update ironic from branch 'master'
to 36251de6f1090d7bdfc8b6e6ebae44b35aeed0db
- Merge "Add note regarding metal3 ci job in CI config for stable runs"
- Add note regarding metal3 ci job in CI config for stable runs
Change-Id: I2a9cc075579356c2d3e47b414ae8af162eea1608
* Update ironic from branch 'master'
to ffd0e5c95d8da6e82e4106108831c347dc437b9f
- Merge "db: Replace use of Engine.execute() method"
- db: Replace use of Engine.execute() method
Resolve the following RemovedIn20Warning warning:
The Engine.execute() method is considered legacy as of the 1.x
series of SQLAlchemy and will be removed in 2.0.
Closes-Bug: #2061345
Co-Authored-By: Stephen Finucane <stephenfin@redhat.com>
Change-Id: Ib0519af8a15ca02e351f8d739d52f4e658f7615a
* Update ironic from branch 'master'
to 7d1bc77861a42dd36c458dd7cdf5db46357a1dec
- Merge "Handle servicing failures in the Redfish BIOS interface"
- Handle servicing failures in the Redfish BIOS interface
Change-Id: I58a27ec9e3646b143fc0874f033849056848c411
* Update ironic from branch 'master'
to 60b263df50e953afb79330eb2d90833d362ddf30
- Merge "Fix get_async_step_return_state to account for servicing"
- Fix get_async_step_return_state to account for servicing
Change-Id: I502be5613ffef7c2f51eafd0a10d5e9c5d5ec2a4
* Update ironic from branch 'master'
to 9d8d5a9387d31577ea618c72ebdfb2c893bb7d4b
- Merge "Remove unused DEFAULT_NEUTRON_URL constant"
- Remove unused DEFAULT_NEUTRON_URL constant
This constant is not used by any logic in the current code.
Change-Id: I75122a8c8a3698227b381bb72d58c09d8b77982f
* Update ironic from branch 'master'
to 22aa29b864eecd00bfb7c67cc2075030da1eb1d0
- Stop assuming service steps have priorities
Unlike clean, deploy and verify steps, service steps cannot run
automatically and thus do not have a usable notion of priority. It's not
possible to provide a priority through the API but our validation code
still requires it. This change gets rid of most priority handling for
service steps, leaving only some foundation for future enhancements.
Change-Id: I82aefc03a5c062b67e0f457612fe568399226dc8
* Update ironic from branch 'master'
to 7737a2549da6226aa6640536fc50689d82837741
- Merge "Add states.SERVICING and SERVICEWAIT to need_prepare_ramdisk"
- Add states.SERVICING and SERVICEWAIT to need_prepare_ramdisk
Currently, service steps do not work with virtual media deployments
because states.SERVICING and states.SERVICEWAIT are missing from the whitelist
of valid provision_states. This change resolves this issue.
Change-Id: I5e3ec08d128b35385f2d90c9c852140b757b8dbf
* Update ironic from branch 'master'
to 604ff49456a444b837fea3ced70ded97b174d0fe
- Merge "Fix redfish detach generic vmedia device method"
- Fix redfish detach generic vmedia device method
Fixes usage of redfish detach virtual media feature to be conform to
the general implementation.
Before the detach virtual media API call using redfish driver was not
working as intended and caused the operation to fail.
The method implementation was allowing only a single device_type
while it should be multiple devices to match the conductor manager
implementation.
Change-Id: I9edd3b77eeb3ec1b0484d4e6f0c6dea53e83f9ad
* Update ironic from branch 'master'
to d5802f832f704ec0739f3c32d7b795931a3e4a18
- Merge "Expose conductor online boolean for accurate alive"
- Expose conductor online boolean for accurate alive
Currently the online database column is not considered when displaying
the "baremetal conductor list" Alive status. This means that when a
conductor is stopped gracefully it will be shown as (inaccurately)
alive for the duration of [conductor]graceful_timeout.
This change adds the online field to the alive evaluation, so the
conductor must be online *and* have a recent heartbeat.
Change-Id: Ic5a8d56ec236faca1b9797bd0d3e42c956469fab
* Update ironic from branch 'master'
to 243e14359afa36cd7344f0ca4d9e25f7ab193256
- Merge "Fix generating local paths when connecting virtual media"
- Fix generating local paths when connecting virtual media
The generate path does not contain the node UUID, causing conflicts.
Also make sure to always clean up any existing files first.
Change-Id: I30f948d64e7b87f33841dc22828db60338a62dd8
* Update ironic from branch 'master'
to d68aea2ebecbf98878573f25570af3e0196d6f5f
- Merge "ci: automatically set the branch for IPA to match TARGET_BRANCH"
- ci: automatically set the branch for IPA to match TARGET_BRANCH
... if present, use TARGET_BRANCH parameter to influence which
branch is used for IPA downloads.
Change-Id: I9d8878ddc56f1cd90debfc2e61838162fe39e039
* Update ironic from branch 'master'
to bc260cc8380b894975c5f0b4c7a9dd0903c7c290
- Merge "Do not rely on predefined UUIDs in tests"
- Do not rely on predefined UUIDs in tests
Change-Id: I0e9d73351a92e133cd6c484b5fb415ae005314b0
* Update ironic from branch 'master'
to 565d18f0d5ca9b4db397bf0666bbba2c93ef5d59
- Merge "Fix Reopen Web Console Duplicate Sol Session"
- Fix Reopen Web Console Duplicate Sol Session
Reopen web console may occasionally result in duplicated
sol session. get_console action open
one console process while another sol session remains.
This patch adds "sol deactivate" action before get
console. Make sure the current connection always a success.
Change-Id: Ie5d9c94a3e9e3561b6aa1a52462d6739662d4eb0
* Update ironic from branch 'master'
to 0d6bbb362033ed9fa2802127c8cf9391151c9cd8
- Merge "Drop fallback to unmanaged inspection for virtual media and UEFI boot"
- Drop fallback to unmanaged inspection for virtual media and UEFI boot
It is not expected that nodes configured this way start PXE-booting.
Change-Id: I9bc5ab73bb54e0612fb6025f10c4d41a5b8842cb
* Update ironic from branch 'master'
to 2cb8eafc6a2249436c8410e03c17f526ae8741a3
- Merge "Fix new codespell issues; tweak config"
- Fix new codespell issues; tweak config
Configuration was fine for the gate, but I've updated it to ignore
directories and files that can be found in a well-used development
checkout.
Fixed any new spelling issues.
Change-Id: Icef5addba938b27911c26e841a37a2e9ba3fbe43
* Update ironic from branch 'master'
to 272344e95131ccd4dab99630fe95878f9773d795
- Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I3394a59586b253c4270b5590ff63b86ab8399d57
* Update ironic from branch 'master'
to 9fa0320458a068bc100c3fb36a8774f55a95c767
- Merge "Add redfish https boot CI job"
- Add redfish https boot CI job
Adds a job which utilizes the redfish-https boot mechanism
code which recently landed in ironic, which operates similar
to virtual media
Change-Id: Iad55a263ed34e6b121495b72a3c79449d7471901
* Update ironic from branch 'master'
to 388b9ddcacc6539433fe2d37534414126dd47826
- Update min required version of scciclient
For compatibility with pysnmp-lextudio and pyasn1 we increase the
minimum required version of python-scciclient to latest available.
Also capping proliantutils to avoid breaking changes.
Change-Id: I64587d24383dc05927135d7e7e3a2a6975a58558
* Update ironic from branch 'master'
to cd117d1ed9ab8d5fd65d84f0a2662d59b9bf4d7e
- Update master for stable/2024.1
Add file to the reno documentation build to show release notes for
stable/2024.1.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.
Sem-Ver: feature
Change-Id: Ie669c480f361e7df0ba0566931685a3bf38045a2
* Update ironic from branch 'master'
to 99b1f9c47985be3a93a71558b444badfec0e16fd
- Merge "Bump proliantutils for pyasn1 compatibility"
- Bump proliantutils for pyasn1 compatibility
Latest version moves back to lextduio pysnmp keeping pyasn1
as dependency.
Change-Id: I042a74eccacd6f358daf04d4ccbd53390bcc8df8
* Update ironic from branch 'master'
to 5c00b7cf0bc9393159535328124d6fdec32ec51d
- Merge "Fix data length exceeding limit error"
- Fix data length exceeding limit error
This commit increases the length of the 'user' column to
accommodate longer UUIDs, ensuring that the full user UUIDs are stored
without exceeding the column limit.
Closes-Bug: #2054594
Change-Id: I59b435ca2bb5850bb2338228b64868c2003bfea3
* Update ironic from branch 'master'
to 60e780fe15773e0c49754c3f7371b43a3bd5d98b
- Merge "Ignore generated config/policy file"
- Ignore generated config/policy file
These files should be generated by tools and should not be added to
the repository.
Change-Id: I5f262d9c0761d1c7a18675b6da36bd388e446c97
* Update ironic from branch 'master'
to 0237392002aac547e775346997df058cd3a53c64
- Merge "Fix artifical rbac policy constraint that resulted in 500s"
- Fix artifical rbac policy constraint that resulted in 500s
Some of the endpoints are *highly* restricted in ironic's newer
more stringently enforced RBAC world. Some of these endpoints would
emit 500s by default, when realistically it was the policy definition
saying "only system scope could be used" for the endpoint, but the
reality is that 403 is what should have been returned for a client to
properly understand what is going on.
Change-Id: If5e13764dad886ba3ee1a848f3ff9f3279f4d7f6
* Update ironic from branch 'master'
to 10785a0550af30e0bca74444c838cd3a088cc5c4
- Release mappings for 23.1, 24.0, 24.1/2024.1
Release mappings! We made a Caracal!
Change-Id: I0106d43080746e1b159f4a54e6808d477cfbef44
* Update ironic from branch 'master'
to 8922c79b7c088ce51aae16c4c1ccef6739a91381
- Merge "Support more standard way of passing lists via query strings"
- Support more standard way of passing lists via query strings
Currently, arguments like "fields", "shared" or the new "device_types"
only accept comma-separated strings. While there is no single standard,
the most common approach is to repeat the arguments, i.e.
NOT /nodes?fields=uuid,name
BUT /nodes?fields=uuid&fields=name
Unfortunately, at least GopherCloud already relies [1] on the more common
(but not currently working in Ironic) behavior. Let's make it work.
[1] 8455d01343/openstack/baremetal/v1/nodes/testing/requests_test.go (L87)
Change-Id: Ia780b10986929d79dc4f334d278bcb00a9984fd0
* Update ironic from branch 'master'
to 2f71e5d51262c45d47d045b1bf35cc3a750ce0da
- Merge "Update regex to detect closed branch"
- Update regex to detect closed branch
... based on the change made in reno recently[1].
[1] https://review.opendev.org/c/openstack/reno/+/910547
Change-Id: I0eea3de292c5e0f57d2136064e70227c5865c8b8
* Update ironic from branch 'master'
to 96565b6894f117cd4b79e25d026df6b1423664b6
- Merge "Tempest test with only wholedisk for some jobs"
- Tempest test with only wholedisk for some jobs
Changing the ironic-tempest-uefi-redfish-vmedia and
ironic-tempest-ovn-uefi-ipmi-pxe jobs to only run
tempest test_baremetal_server_ops_wholedisk_image.
We saw failures on the partition tests for this jobs.
Related-Bug: #2057972
Change-Id: I2e26d7955ade11046bf89b6f4c9c2c4f16da1574
* Update ironic from branch 'master'
to bf1aadf2bc01c088652954d6cd387e13095c30f2
- Merge "Allow usage of virtual media via System"
- Allow usage of virtual media via System
DMTF now changes their Virtual Media URI to support Systems. Redfish driver now
support this resource to boot, so it is needed that Ironic have a way to use it.
Closes-Bug: #2039458
Change-Id: I66e8edb847e93f96374072525222f05e7561fb07
* Update ironic from branch 'master'
to 16b0ea709a2dd20ebbe71229e36801daf009b0ab
- Merge "Implement generic redfish vmedia attach detach"
- Implement generic redfish vmedia attach detach
This patch adds implementation of attach/detach generic virtual
media device to the Redfish driver.
Also the redfish vendor eject vmedia action is now deprecated
and it will be removed during the next cycle in favor of the
generic API.
Change-Id: I9daff59128f537a3da2e882adf5c97be9c4ab8d9