* Update os-vif from branch 'master'
to 260fed10544ec6b3acc3f69d5a1913d3f41b5780
- Merge "reno: Update master for unmaintained/victoria"
- reno: Update master for unmaintained/victoria
Update the victoria release notes configuration to build from
unmaintained/victoria.
Change-Id: Icfd5238438045fb632c1b1a053b28678b0414340
* Update os-vif from branch 'master'
to 0ab31df34031a40db439e69a0397309645fcffe4
- Merge "reno: Update master for unmaintained/wallaby"
- reno: Update master for unmaintained/wallaby
Update the wallaby release notes configuration to build from
unmaintained/wallaby.
Change-Id: Iab42dd3d6150026669c52b2e39702e6a067a8fce
* Update os-vif from branch 'master'
to 36e77894bf705470d7e8ddd76a6626937417e708
- Merge "reno: Update master for unmaintained/xena"
- reno: Update master for unmaintained/xena
Update the xena release notes configuration to build from
unmaintained/xena.
Change-Id: I451cebf055061beba6c69e81d7980b206797c193
* Update os-vif from branch 'master'
to 8a92922e36bb24befced42527d91028c606add7c
- Merge "tox: Drop envdir"
- tox: Drop envdir
tox now always recreates an env although the env is shared using envdir
options.
~~~
$ tox -e genpolicy
genpolicy: recreate env because env type changed from
{'name': 'genconfig', 'type': 'VirtualEnvRunner'} to
{'name': 'genpolicy', 'type': 'VirtualEnvRunner'}
~~~
According to the maintainer of tox, this functionality is not intended
to be supported.
https://github.com/tox-dev/tox/issues/425#issuecomment-1011944293
Change-Id: Ib73364b71234d25d50920495f91e1a3e18c96bcd
* Update os-vif from branch 'master'
to ca62f9cd61592bd7f516cd9ff7ed3acdb57adbb0
- Merge "Update python classifier in setup.cfg"
- Update python classifier in setup.cfg
As per the current release tested runtime, we test
till python 3.11 so updating the same in python
classifier in setup.cfg
Change-Id: Ie609845195ceea1d3bc71dfce6b1f214f0648dc4
* Update os-vif from branch 'master'
to 6174366bf0a8dcf4e727848ac0c6579e2d15d47d
- Update master for stable/2024.1
Add file to the reno documentation build to show release notes for
stable/2024.1.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.
Sem-Ver: feature
Change-Id: If84e5ae82ffb6bbc6d58ac4526404f8504f0aec8
* Update os-vif from branch 'master'
to 2f53c930f9fe857f4d15549b28ec74120d579f79
- Merge "Fix missing or unnecessary dependencies"
- Fix missing or unnecessary dependencies
This fixes the following problems with current requirements and test
requirements.
- netaddr is not used
- oslo.serialization and oslo.utils are imported but are not listed in
requirements.
This also fixes the workaround for python 2 from setup.py because
python 2 support was removed some time ago.
In addition, the described behavior of pip was already fixed in
recent versions.
Change-Id: I63a56adf73c221c8f5f725c2689ddf953f90c654
* Update os-vif from branch 'master'
to 4d2d89e041bc17cb987b5ef9383c4c09390e18b9
- Merge "Drop wrong stacklevel"
- Drop wrong stacklevel
This is follow-up of 077e43698e663176734ab8b2fbc3032da47f641f and fixes
the wrong stack level for deprecation warning. We don't have to look
for the point of upper caller.
Change-Id: I615d995c42e6ff689d25f5db8026d9cd684d93ad
* Update os-vif from branch 'master'
to 65db98dc4e932e6e0d1225378078e19ea4466f0e
- reno: Update master for unmaintained/yoga
Update the yoga release notes configuration to build from
unmaintained/yoga.
Change-Id: I70f0efd7e01211ce851380844b1e77f8bd53ba4c
* Update os-vif from branch 'master'
to 03a53003f88cd41b511a487c87acf1c73899504e
- Merge "Deprecate Windows support"
- Deprecate Windows support
Because WinStackers project has been retired, running OpenStack on
Windows operating systems is no longer maintained.
Change-Id: Ic5971ee22aa309a8b46f21fccaa8be7c0091fb0c
* Update os-vif from branch 'master'
to 458e8d5d9cf2668e52d1fd268afc38bc9aad04b5
- Update master for stable/2023.2
Add file to the reno documentation build to show release notes for
stable/2023.2.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.
Sem-Ver: feature
Change-Id: I64f66933e552981b4affd841f640742d1f80bbb9
* Update os-vif from branch 'master'
to 0a0dec37e42e220ffa750650027714bd7289faa1
- Don't break traffic if port already exists
Nova compute service plugs VIF on service init, it triggers
rules reinitialization for iptables filter. But it breaks
traffic in case isolate_vif is used by assigning dead VLAN
to the port. This patch prevents dead VLAN assingment
for ports that exists.
Co-Authored-By: aarefiev@mirantis.com
Closes-Bug: #2023300
Change-Id: Ib1b7467fce9facfbfcd698bf6e9f950c0cead650
* Update os-vif from branch 'master'
to da742a849a1b8b2f3ca9485b38c5bb54c1bb6c75
- Merge "set default qos policy"
- set default qos policy
This change modifies the os-vif ovs plugin to set a default
tc qdisc on ovs interface when the host os is not windows
and the system datapath is used.
This change fixes a "silent" bug in the functional test code due
to a change in an ovsdbapp function signiture to accpet a new paramater.
Closes-Bug: #2017868
Change-Id: Id9ef7074634a0f23d67a4401fa8fca363b51bb43
* Update os-vif from branch 'master'
to 79be30fd136d493f2fbcd921e83b2767fbc2891d
- remove focal based jobs
ubuntu 20.04 is no longer a tested runtime.
This patch removes the os-vif-ovn-ubuntu-focal job
from the check and gate pipeliens and removes the job defintion.
Change-Id: I3304b7a1d489e281fbceff19dcc97cbd6dadee13
* Update os-vif from branch 'master'
to 6795bf63a25f24dbb295146b7eb7a63186c460c0
- Update master for stable/2023.1
Add file to the reno documentation build to show release notes for
stable/2023.1.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.1.
Sem-Ver: feature
Change-Id: I71e5f6c041bf8445da99bfb6f284b69f2ae10350
* Update os-vif from branch 'master'
to 54bae86c25ca4c87010421adf9e4aa066bd3eb0d
- Merge "Implement "BaseCommand" result property"
- Implement "BaseCommand" result property
``ovsdbapp.api.Command`` abstract class will declare the "result"
property in [1]. This should be available in the next library
release.
Related-Bug: #1995078
[1]https://review.opendev.org/c/openstack/ovsdbapp/+/871836/11/ovsdbapp/api.py
Change-Id: I98fd0be0b7d3ca8dd631b00b75515b1ad0d61f3c
* Update os-vif from branch 'master'
to b052dfe2f1de6e16b76a7a58274fb4023a705f9d
- Increase the swap size to 8GB in tempest jobs
That should reduce or avoid the ocurrency of frequent OOM exceptions
during the execution of the tempest tests.
Change-Id: Ie67df706a560cd510015f9fb3c94d9353dd6159f
* Update os-vif from branch 'master'
to 03417ac879533f7c4b75b0834afec52bef17a74f
- Update gate jobs as per the 2023.1 cycle testing runtime
As per 2023.1 testing runtime[1], we need to test on Ubuntu
Jammy (which will be taken care by tempest and devstack patches
to move base jobs to Jammy) and at least single job to run on
Ubutnu Focal (for smooth upgrade). Also, python 3.10 testing is
voting now.
This commit adds a new job to run on focal which can be removed
in future cycle when testing runtime drop the requirement of Focal
testing.
[1] https://governance.openstack.org/tc/reference/runtimes/2023.1.html
Change-Id: I17cc6d619e7becff6b33fd66a47d3a9621b823fb
* Update os-vif from branch 'master'
to 2f31947393ce2a68f6623723fdd85abdac9a1786
- Make tox.ini tox 4.0.0 compatible
* removed skipdist=True to make sure os-vif is available in the virtual
env
* removed basepython = python3 as we assume all developer switched to
python3 in their env already
* removed ignore_basepython_conflict = True as without the basepython
definition generative targets now work without conflict
Also squashed in the commit fixing the functional target as both fix is
needed to unblock the gate:
add CAP_DAC_OVERRIDE to test privsep contexts
This change modifes the privsep contexts used by the test
code to create inteface without using the os-vif plugins.
The os-vif functional tests actully create ovs and linux
brdiges and dummy netdevs. to ensure the drier work correctly
the functional tests have a simpler test only version of the
port/brige management commands that are used to prepare
and validate the test env. The simpler implementation uses
standard linux commandline tools like "ip" or "ovs-vsctl"
which on ubuntu 22.04 require the addtion of CAP_DAC_OVERRIDE
to work around socket/file ownership issues.
To avoid adding capablities at runtime that are not required
this change modifes the existing test only context in
the os_vif.tests.functional.privsep module and add a new test
context for the vif_plug_ovs plugin
Change-Id: Ide357cb64a8d128ff8ad978abae6a039e814d8a9
* Update os-vif from branch 'master'
to 05c8a6880ceba1d9ccafbef23cf9701ac45488c8
- Merge "Move mtu update request into ovsdb transaction"
- Move mtu update request into ovsdb transaction
os-vif currently set the requested mtu as part of separate request
to the port add command. As a result the port is initially created
with mbufer pool for the jumboframe size, which results in an
error in openvswitch-vswitch logs.
This change moves the mtu update request into ovsdb transaction.
Closes-Bug: #1959586
Change-Id: I1acd74efc100c6f949b5c72525c455aebfa2c50e
* Update os-vif from branch 'master'
to b0298b5350f21f858f2bf72c5d18e3019a696514
- adapt to stestr 4.0 release
This change removes usage of --black-regex which is no longer supported
as of stestr 4.0.0. The min version of stestr is increased to 3.1.0
which adds --exclude-regex as a replacement.
Change-Id: I24424aeeb178fd9ab1b736cb689a73f7bd8bd572
* Update os-vif from branch 'master'
to 35705ba59f379aca234206d7a43b14a0c9d3d087
- Switch to 2023.1 Python3 unit tests and generic template name
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for antelope. Also,
updating the template name to generic one.
See also the PTI in governance [1].
[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html
Change-Id: Ie53a00cebcabea9fbdc5578333c11725d81f4fc6
* Update os-vif from branch 'master'
to f8d504049ac42bfc546e02e20f06658f5a92af1f
- Update master for stable/zed
Add file to the reno documentation build to show release notes for
stable/zed.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/zed.
Sem-Ver: feature
Change-Id: If59aa141d86f9096305498c4d56d35bc24729343
* Update os-vif from branch 'master'
to 771dfffcd90dcd7c8c95c41744092f5ad4917be3
- update ci since linuxbridge is now experimental
neutron now considers linuxbridge to be experimental
This change enables the linuxbridge feature in the
linuxbridge job. we do not currently declare the
linuxbridge os-vif plug as experimental as it has
been stable for many release and we do not have an
experimental concept in os-vif.
Change-Id: Ia275d1c3a9a9cf63238cf354c8e7d93ed59097a2
Closes-Bug: #1980948
* Update os-vif from branch 'master'
to 18bd440bbe5692229ac029937000814393898298
- Merge "Check for hybrid plugging in OVS"
- Check for hybrid plugging in OVS
There is a cold migration scenario that leaves some interfaces behind in
case port binding changes from hybrid to direct plugging between the
nodes. This patch adds functionality that checks presence of
intermediate linux bridge and clears things up properly if found.
Signed-off-by: Jakub Libosvar <libosvar@redhat.com>
Change-Id: Ic5b38a0467b3c18e38bec005d80cd1f5f0e66b28
* Update os-vif from branch 'master'
to 1651a730c1c9a8bd38f03d47f7b51b4bb6949575
- Drop lower-constraints.txt and its testing
As discussed in TC PTG[1] and TC resolution[2], we are
dropping the lower-constraints.txt file and its testing.
We will keep lower bounds in the requirements.txt file but
with a note that these are not tested lower bounds and we
try our best to keep them updated.
[1] https://etherpad.opendev.org/p/tc-zed-ptg#L326
[2] https://governance.openstack.org/tc/resolutions/20220414-drop-lower-constraints.html#proposal
Change-Id: I38a41071ac540e3b58f9d18ead88b86203a4c843
* Update os-vif from branch 'master'
to b95daaecd39fcef41243a0ae5de17601930bba78
- Merge "Delete trunk bridges to avoid race with Neutron"
- Delete trunk bridges to avoid race with Neutron
During the Zed PTG it was decided that to solve the race condition
between os-vif and Neutron when deleting trunk bridges, os-vif will be
responsible of both the creation and the deletion of the bridge (see Day
2 first topic at [1]). This change adds the code to delete trunk
bridges.
[1] https://lists.openstack.org/pipermail/openstack-discuss/2022-April/028164.html
Change-Id: I7d834a0c31c801e96002f42f86409ba274c234e6
* Update os-vif from branch 'master'
to 124933574ce739b1e756ce814106b79e3b6c84dd
- Merge "Change minversion of tox to 3.18.0"
- Change minversion of tox to 3.18.0
The patch bumps min version of tox to 3.18.0 in order to
replace whitelist_externals with allowlist_externals option:
https://github.com/tox-dev/tox/blob/master/docs/changelog.rst#v3180-2020-07-23
Change-Id: I38c2a7277f33203f3a8b51f01d75ce15730a969f
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
* Update os-vif from branch 'master'
to a12edbfe5434261eff637fd98b2abe042af99b4e
- update job template to zed
This change updates the python job template to zed
this will disable py36 jobs and enable the default set
for zed. The repo presently used the yoga template
which now fails as a result of project dropping py36 support.
This change also increases the min python reqired to 3.8
to match the zed supported runtimes and adds a release note.
Change-Id: I50253be0c99df9b363da5f6cc0c8502536dbbb43
* Update os-vif from branch 'master'
to 987c76d7c8e0a16b3db65ba1782f8661d48698ce
- Merge "Fix race with DPDK and vhostuserclient mode"
- Fix race with DPDK and vhostuserclient mode
When a VM is rebooted and it has a port in a Neutron trunk with DPDK and
vhostuserclient mode, Nova will delete the OVS port and then recreate it
when the VM reboots. This quick transition can create a race condition
whereby Neutron deletes the trunk's bridge between the interface removal
and addition by os-vif, so the latter operation fails because the bridge
doesn't exist anymore. To fix this, ensuring the bridge existance and
the vif addition becomes an atomic operation from the point of view of
the OVSDB transaction.
This change is associated to [1] on the Neutron side.
[1] https://review.opendev.org/c/openstack/neutron/+/829139
Partial-Bug: #1869244
Change-Id: Id7ece4ebc9239d9776c43b8d7f9e82b0319a08c6
* Update os-vif from branch 'master'
to 93fde12c39d7784ca47beaf1e801f9e471c3775b
- Update master for stable/yoga
Add file to the reno documentation build to show release notes for
stable/yoga.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/yoga.
Sem-Ver: feature
Change-Id: Ide7a6f4c4307464087612b481a109111d49af843
* Update os-vif from branch 'master'
to 8fa891805c04e2760d6fc290960b50fb70d7f83b
- Updating python testing classifier as per Yoga testing runtime
Yoga testing runtime[1] has been updated to add py39
testing as voting. Unit tests update are handled by the
job template change in openstack-zuul-job
- https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286
this commit updates the classifier in setup.cfg file.
[1] https://governance.openstack.org/tc/reference/runtimes/yoga.html
Change-Id: I12c88a6154a0b004bd0008bf030644b25b6349f1
* Update os-vif from branch 'master'
to a85d276195d539ae457884ea36781891e8075ac7
- Merge "only register tables used by os-vif"
- only register tables used by os-vif
This change limits the tables registered in the native driver
to the set actully used by os-vif. This will shorten the inital
startup time and reconnection time if the ovs db connection is dropped.
as a result this will help mitigate bug #1929446 where on reconnection
the nova compute agent can stall until reconnection is completed.
Change-Id: I635dff2b4fcff905ca8f431eb7e928265200f92a
Partial-Bug: #1929446
* Update os-vif from branch 'master'
to b0c42708a5d6b9aab8117215219b8aacbe612ff1
- Merge "Use TCP keepalives for ovsdb connections"
- Use TCP keepalives for ovsdb connections
Ultimately, this is something that should be fixed in python-ovs,
but setting the SO_KEEPALIVE socket option benefits the client by
removing the need to send 'echo' requests, which can time out on
an overloaded ovsdb-server, which causes a disconnection which then#
adds even more load on the ovsdb-server as it has to send the entire
db contents over the wire after the connection is restored.
This patch ports the optimisation form neutron to reduce the likelyhood
of a reconnection which can cause the nova compute agent to hang
temporarily while the connection is reestablished.
Change-Id: I984ec62730276f8ee60d71a02a98fbfc4c37f7d8
Related-Bug: #1930926
Partial-Bug: #1929446
* Update os-vif from branch 'master'
to b30c7fc7f88bcd983836f25aed94382b8d48e41f
- Add Python3 yoga unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for yoga.
See also the PTI in governance [1].
[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html
Change-Id: I490ce12e1651ecfcd6ed7ca721ccd5ea4f5ef171
* Update os-vif from branch 'master'
to 067fd6a3d2b8d7e0a6cbae0b93538bd57dba06eb
- Update master for stable/xena
Add file to the reno documentation build to show release notes for
stable/xena.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/xena.
Sem-Ver: feature
Change-Id: I95ebbc634530e097b223adb01a21573f13b89766
* Update os-vif from branch 'master'
to b837c1a74f37191692a820711e431a75516a4abf
- add configurable per port bridges
This patch add a new configuration option to use
per port bridge when hybrid_plug is false.
This can be used with OVN to reduce packet loss
during a live migration.
OVN can only install openflow rules when a port both has
external_ids set and an ofport-id assigned.
Since the ofport-id is only assigned when a netdev matching
the port name exists connected to the dataplane, OVN cannot
install the flows until libvirt create the tap on the destination
host during a live migration.
On loaded systems this can result in multiple seconds of packet loss.
To address this we introduce per port bridges which are connencted
to the integration brige by a patch port pair. Since the patch port
will exist on the dataplane during pre live migration OVN can install
the flows on the integration bridge before we begin the migration reducing
or avoiding packet loss.
Change-Id: I0d55ccbef5b585330b5512e67e442b80304a2e73
Depends-On: https://review.opendev.org/c/openstack/nova/+/797428
Closes-Bug: #1933517
* Update os-vif from branch 'master'
to b75af3ae1303cf449e881f14191bb10a3fdc373d
- update os-vif ci to account for devstack default changes
This change restores the os-vif-ovs-iptables job to deploying
with ml2/ovs follow the devstack default change to ovn.
This change replaces the os-vif-ovs job with an os-vif-ovn jobs.
This change also simplifies teh os-vif-ovs-base job by disabling
DVR since that does not change the behavior of os-vif.
This change reduces the job time out to 7800 and moves it
to os-vif-tempest-base.
Closes-Bug: #1933590
Change-Id: Icda02ec4b5be18c3646af7988f210baf4ceb0890
* Update os-vif from branch 'master'
to e93736711920afe64a850f564dddefbd704975cd
- Merge "setup.cfg: Replace dashes with underscores"
- setup.cfg: Replace dashes with underscores
Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:
UserWarning: Usage of dash-separated 'description-file' will not be
supported in future versions. Please use the underscore name
'description_file' instead
[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb
Change-Id: Idf24b85695e7375765fcd6cc4c8988dc2a6be790
* Update os-vif from branch 'master'
to c9b20777860fbf4dc34980fdee23e03bd332083f
- Creating oslo.config.opts entry_points for plugins
To assist with automated configuration validation, we need entry points
for oslo.config.opts for each one of the plugins.
Change-Id: I7fc132f917949d147dd6371d54e01a6cfd995aae
* Update os-vif from branch 'master'
to d8af3568b8b92748f61029a96c46fd513b6795c2
- Add Python3 xena unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for xena.
See also the PTI in governance [1].
[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html
Change-Id: I5978186792c12a98bc0af2f3bb8aeb8db88ae799
* Update os-vif from branch 'master'
to e1ad9ea7f47b0b1602154b7624755912cc4c2f90
- Update master for stable/wallaby
Add file to the reno documentation build to show release notes for
stable/wallaby.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.
Sem-Ver: feature
Change-Id: I325cda1fb9d0b0027c1f95db264483909bb57594
* Update os-vif from branch 'master'
to 6167658e5b61b5408c4a631cc41b7bfc6f16f164
- Merge "Drop use of deprecated collections classes"
- Drop use of deprecated collections classes
These were moved in Python 3.3 and the aliases are going away in 3.10.
Preempt that change.
Change-Id: Id09b52ac5e746d8e4818cb4218422fe36f5e72f4
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Update os-vif from branch 'master'
to 44d8937148aac1a61f40e59d3271c45f9fe6aa03
- Resolve dependency issues
This is totally broken with the pip 20.3 resolver. Attempts to fix the
lower-constraints file manually didn't work out, so start specifying
only the direct dependencies here, relying on upper-constraints for the
given release to restrict everything else.
Two dependencies, python-subunit and testrepository, are removed as
these are no longer necessary. Another, hacking, is moved to 'tox.ini'
since we're not managing this via the u-c system and don't need this
here.
Change-Id: I4bdc0d422813ecee1566256ec237d34f200406ee
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Update os-vif from branch 'master'
to 0aa1ac38596d1790885dfb82bb939981c1b9e1cd
- Fix hacking min version to 3.0.1
flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.
Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.
To avoid similar gate break in future, we need to bump the hacking min
version.
- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html
Change-Id: I2155491aa65b11c36e0f2f7f0b53b405fb2b387a
* Update os-vif from branch 'master'
- Merge "Fix - os-vif fails to get the correct UpLink Representor"
- Fix - os-vif fails to get the correct UpLink Representor
Till kernel 5.7 PF and VF representors are exposed as virtual device.
They are not linked to its parent PCI device like how uplink
representor is linked.
Starting from kernel 5.8 due to new change [1] the PF and VF representors are
linked to their parent PCI device, and so "get_ifname_by_pci_address" fails
to get the correct UpLink Representor.
This patch modifys the behviour of "get_ifname_by_pci_address" to
check the physical port name of the netdev in
vf_pci_addr_path/physfn/net to match the formart for the uplink "p\d+".
[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=123f0f53dd64b67e34142485fe866a8a581f12f1
Closes-Bug: #1892132
Change-Id: I49f6ae3f0e6bfbf555c8284bfd70371ce90da0c7
* Update os-vif from branch 'master'
- tox: Rename 'UPPER_CONSTRAINTS_FILE' -> 'TOX_CONSTRAINTS_FILE'
This is the new name recommended by the base zuul jobs [1]:
Path to a pip constraints file. Will be provided to tox via
``TOX_CONSTRAINTS_FILE`` (deprecated but currently still supported
name is ``UPPER_CONSTRAINTS_FILE``) environment variable if it exists.
While we're here, we remove a wholly unnecessary layer of environment
variable-based indirection.
[1] https://opendev.org/zuul/zuul-jobs/raw/branch/master/roles/tox/README.rst
Change-Id: Ic82672f5376988ef6c40d2aaebf1a9e59d3538ad
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>