Remove 'usedevelop = true' and 'skipsdist = true', the combination of
which now means we don't install dependencies. Also remove the
basepython setting, which is no longer needed since we don't have any
Python 2-first distros to worry about. Finally, remove the
lower-constraints job and we no longer test for these.
Change-Id: I5b4b8cc1facb6e18cf12d33ea8113d47a0a76235
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Commonly used for testing virtual environments (at least by me).
Change-Id: I3b711bd3464a2ca2a8dced37d9d6ec328b8bf827
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The tox option to skip source distribution building is skipsdist,
but this seems to be often misspelled skipdist instead, which gets
silently ignored and so does not take effect. Correct it
everywhere, in hopes that new projects will finally stop copying
this mistake around.
See https://tox.readthedocs.io/en/latest/config.html#conf-skipsdist
and https://github.com/tox-dev/tox/issues/1388 for details.
Change-Id: I639066169913072b992c0e1073f9398d6ac8cdd2
pip 20.3 finally includes a proper dependency resolver. Its use is
causing the following error messages on the lower-constraints job:
ERROR: Could not find a version that satisfies the requirement
hacking<3.1.0,>=3.0.1
ERROR: No matching distribution found for hacking<3.1.0,>=3.0.1
Resolve this by moving the 'hacking' and 'flake8-import-order'
dependencies from 'test-requirements.txt' to 'tox.ini' since we don't
need to use our constraints machinery for linters.
While we're here, also drop 'bandit' from 'test-requirements.txt'. This
was introduced in change I691829c1224557d1d239c9f665ac539d0f13c4d3 but
commit f78173f0e1 (there's no change ID)
removed the 'bandit' testenv from 'tox.ini' meaning we no longer use
this anywhere.
Change-Id: I744efd75c4cbf8c630c5f95dc254acff581be959
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Resolves the following warning:
/usr/lib/python3.7/site-packages/tox/config/__init__.py:578:
UserWarning: conflicting basepython version (set 37, should be 36) for
env 'py36'; resolve conflict or set ignore_basepython_conflict
While here, also fix indentation of this file.
Change-Id: I48bf44cf7237554a48180c8bd3537425f0401f30
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The docs requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.
Change-Id: I4bcafc7c7d6905f5478fd4ed106795f21e51012e
Set flake8-import-order version to 0.17.1
Full py3 compatible version.
Add all Python3 modules to stdlib list.
Change-Id: I787202eee18c99aaa659e0267235f4c413a389e9
The repo is Python 3 now, so update hacking to version 2.0 which
supports Python 3.
Blacklist:
W504 line break after binary operator
Fix:
E305 expected 2 blank lines after class or function definition, found 1
Change-Id: I713186061d5484ee2cd5317eb9192646fd3a1099
This is a mechanically generated patch to switch the documentation
jobs to use the new PTI versions of the jobs as part of the
python3-first goal.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Update docs tox environment to build ChangeLog file when using tox -e
docs.
Change-Id: If68bdb33bbf0727d699268d9de511790c8a048be
Story: #2002586
Task: #24320
The TimingSession functionality has been merged into keystoneauth. This
allows us to use the CloudRegion object to get the Session directly.
Change-Id: Ib4c9210e681a2d2d9c5fc40de2c3ede1a5003154
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I01e8cf1b70d7a1501dccd26bf30db52e36dedb38
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: Ieafa2beff7b8d26726765e9044dc0b5824e9339c
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
'pip install -U' ugrades specified packages, this is not necessary
since we use constraints, remove the parameter '-U' from the line.
With tools/tox_install.sh - which a previous change of mine removed -
the -U was not harmful, but with the current set up, it might cause
upgrades, so remove it.
Change-Id: I39d00ea09cc1f83ecf9caaa41365e9f550000c2a
We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.
This follows https://review.openstack.org/#/c/508061 to remove
tools/tox_install.sh.
Change-Id: I0b91ce60a0c315d0d2f5594f7feb2a56755d8625
Adding constraints support to libraries is slightly more complex than
services as the libraries themselves are listed in upper-constraints.txt
which leads to errors that you can't install a specific version and a
constrained version.
This change adds constraints support by also adding a helper script to
edit the constraints to remove osc-lib.
Change-Id: Ie6b8f7a7c46becc80d6cf9251fbd5eb5c9c707b1
There is no this directory openstack/common which was used to keep codes from
oslo-incubator, we have retired oslo-incubator. Removing openstack/commonfrom
all OpenStack code in favor of the Oslo libraries is a project wide goal
for the Ocata release. So don't use this directory any more. We should drop it
for improving searching efficiency.
Change-Id: Ibbd158ff0c18a27e6208c98b5765dd22676c2f72
There is no releasenotes directory, so the tox releasenotes environment
always fails.
Remove the environment and the reno dependency since both are completely
unused.
Change-Id: I721797f7a53965243ab1d4650c994336e36804dc
This change is being proposed as part of the OpenStack Security Project
working session at the Austin 2016 summit. It adds support for running
the bandit[1] security linting tool against the python-openstackclient
codebase. This change adds a targetted environment for bandit and also
adds bandit as part of the pep8 job.
The bandit configuration has been tailored to exclude tests that are
currently producing warning against the codebase. These issues will be
followed up with bug reports and patches.
[1]: https://wiki.openstack.org/wiki/Security/Projects/Bandit
Depends-On: Iccd81c17e84df03d249c1012277dad9cb68c5845
Change-Id: I691829c1224557d1d239c9f665ac539d0f13c4d3
If “ignore” is not set under flake8 in the tox.ini
file there there are defaults set to be ignored.
The depended patch fixes many of the problems.
Change-Id: Ieed2fe1c4654e201d3fe6d40ef93e247ee736f8b
Doc: http://flake8.readthedocs.org/en/latest/config.html#default
Depends-On: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
Closes-Bug: #1548910
as of mitaka, the infra team won't have the resources available to
reasonably test py26, also the oslo team is dropping py26 support
from their libraries. sine we rely on oslo for a lot of our work,
and depend on infra for our CI, we should drop py26 support too.
Change-Id: I66d168ecc755a3ea0e01d5b6344d06d9e0d1378b
Closes-Bug: 1519510
From lifeless: pbr reflects the package dependencies from
requirements.txt into the sdist that tox builds.
Change-Id: I63548ec321b9c59cc935ba8179b1da5b9c90e09b
This commit switches to use ostestr for running tests. ostestr
integrates the subunit-trace output that other projects use for test
output. (in addition to some other ui niceties)
Change-Id: Ib5b5225b2a7bfb7897e1efe55181389d1ae095cb
The functional test gate seems to be broken. The environment
variables are not being passed through.
Change-Id: Ied1f56877e4793c5e88e59d2afb7f1a5b3868560
Stephen Finucane