openstack
/
oslo.log
Code Issues Proposed changes

Fix unintended assignment of "syslog" 

Identifier "syslog" is unintendedly reassigned in _setup_logging_from_conf()
with OSSysLogHandler.
It causes an error in _find_facility() which expects "syslog" as module.
This change fixes the problem.

Change-Id: Icd8486bc008028f6f78f0306d835bf2c4fb9245b
Closes-Bug: #1499620
(cherry picked from commit ff277ae1e9)
This commit is contained in:
Masaki Matsushita 2015-09-25 15:29:38 +09:00 committed by Matt Riedemann
parent f2f10a15d5
commit 83dd60562f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oslo_log/log.py
View File

@ -337,10 +337,10 @@ def _setup_logging_from_conf(conf, project, version):
facility = _find_facility(conf.syslog_log_facility)
# TODO(bogdando) use the format provided by RFCSysLogHandler after
# existing syslog format deprecation in J
syslog = handlers.OSSysLogHandler(
syslog_handler = handlers.OSSysLogHandler(
facility=facility,
use_syslog_rfc_format=conf.use_syslog_rfc_format)
log_root.addHandler(syslog)
log_root.addHandler(syslog_handler)
datefmt = conf.log_date_format
for handler in log_root.handlers: