Remove unused IncomingMessage.done()

We appear to not have a use for this. I had originally thought we might
use this to ack messages one they've been processed and replied to, but
we actually have always acked messages as soon as they have been
deserialized and queued for dispatching.

Change-Id: I8e1fd565814f3b5e3ba0f1bc77e62ed52ff08661

oslo/messaging/_drivers/amqpdriver.py

@@ -65,11 +65,6 @@ class AMQPIncomingMessage(base.IncomingMessage):
             self._send_reply(conn, reply, failure)
             self._send_reply(conn, ending=True)
 
-    def done(self):
-        LOG.info("done")
-        # FIXME(markmc): I'm not sure we need this method ... we've already
-        # acked the message at this point
-
 
 class AMQPListener(base.Listener):
 

oslo/messaging/_drivers/base.py

@@ -36,10 +36,6 @@ class IncomingMessage(object):
     def reply(self, reply=None, failure=None):
         "Send a reply or failure back to the client."
 
-    @abc.abstractmethod
-    def done(self):
-        "The message has been dispatched and replied to."
-
 
 class Listener(object):
 

oslo/messaging/_drivers/impl_fake.py

@@ -44,9 +44,6 @@ class FakeIncomingMessage(base.IncomingMessage):
         if self._reply_q:
             self._reply_q.put(reply)
 
-    def done(self):
-        pass
-
 
 class FakeListener(base.Listener):
 

oslo/messaging/_executors/base.py

@@ -39,8 +39,6 @@ class ExecutorBase(object):
             _LOG.error("Failed to process message... skipping it.",
                        exc_info=exc_info)
             incoming.reply(failure=exc_info)
-        finally:
-            incoming.done()
 
     @abc.abstractmethod
     def start(self):